Skip to content

Commit 0050c7b

Browse files
committed
locking/rtmutex: rcu: Add WRITE_ONCE() to rt_mutex ->owner
The rt_mutex structure's ->owner field is read locklessly, so this commit adds the WRITE_ONCE() to an update in order to provide proper documentation and READ_ONCE()/WRITE_ONCE() pairing. This data race was reported by KCSAN. Not appropriate for backporting due to failure being unlikely. Signed-off-by: Paul E. McKenney <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Will Deacon <[email protected]>
1 parent 105abf8 commit 0050c7b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/locking/rtmutex.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ rt_mutex_set_owner(struct rt_mutex *lock, struct task_struct *owner)
5757
if (rt_mutex_has_waiters(lock))
5858
val |= RT_MUTEX_HAS_WAITERS;
5959

60-
lock->owner = (struct task_struct *)val;
60+
WRITE_ONCE(lock->owner, (struct task_struct *)val);
6161
}
6262

6363
static inline void clear_rt_mutex_waiters(struct rt_mutex *lock)

0 commit comments

Comments
 (0)