Skip to content

Commit 00d9220

Browse files
masneybrobclark
authored andcommitted
dt-bindings: display: msm: gmu: move sram property to gpu bindings
The sram property was incorrectly added to the GMU binding when it really belongs with the GPU binding instead. Let's go ahead and move it. While changes are being made here, let's update the sram property description to mention that this property is only valid for a3xx and a4xx GPUs. The a3xx/a4xx example in the GPU is replaced with what was in the GMU. Signed-off-by: Brian Masney <[email protected]> Fixes: 198a72c ("dt-bindings: display: msm: gmu: add optional ocmem property") Acked-by: Jordan Crouse <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent e6cada8 commit 00d9220

File tree

2 files changed

+42
-64
lines changed

2 files changed

+42
-64
lines changed

Documentation/devicetree/bindings/display/msm/gmu.txt

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ Required properties:
3131
- iommus: phandle to the adreno iommu
3232
- operating-points-v2: phandle to the OPP operating points
3333

34-
Optional properties:
35-
- sram: phandle to the On Chip Memory (OCMEM) that's present on some Snapdragon
36-
SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml.
37-
3834
Example:
3935

4036
/ {
@@ -67,50 +63,3 @@ Example:
6763
operating-points-v2 = <&gmu_opp_table>;
6864
};
6965
};
70-
71-
a3xx example with OCMEM support:
72-
73-
/ {
74-
...
75-
76-
gpu: adreno@fdb00000 {
77-
compatible = "qcom,adreno-330.2",
78-
"qcom,adreno";
79-
reg = <0xfdb00000 0x10000>;
80-
reg-names = "kgsl_3d0_reg_memory";
81-
interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
82-
interrupt-names = "kgsl_3d0_irq";
83-
clock-names = "core",
84-
"iface",
85-
"mem_iface";
86-
clocks = <&mmcc OXILI_GFX3D_CLK>,
87-
<&mmcc OXILICX_AHB_CLK>,
88-
<&mmcc OXILICX_AXI_CLK>;
89-
sram = <&gmu_sram>;
90-
power-domains = <&mmcc OXILICX_GDSC>;
91-
operating-points-v2 = <&gpu_opp_table>;
92-
iommus = <&gpu_iommu 0>;
93-
};
94-
95-
ocmem@fdd00000 {
96-
compatible = "qcom,msm8974-ocmem";
97-
98-
reg = <0xfdd00000 0x2000>,
99-
<0xfec00000 0x180000>;
100-
reg-names = "ctrl",
101-
"mem";
102-
103-
clocks = <&rpmcc RPM_SMD_OCMEMGX_CLK>,
104-
<&mmcc OCMEMCX_OCMEMNOC_CLK>;
105-
clock-names = "core",
106-
"iface";
107-
108-
#address-cells = <1>;
109-
#size-cells = <1>;
110-
111-
gmu_sram: gmu-sram@0 {
112-
reg = <0x0 0x100000>;
113-
ranges = <0 0 0xfec00000 0x100000>;
114-
};
115-
};
116-
};

Documentation/devicetree/bindings/display/msm/gpu.txt

Lines changed: 42 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,54 @@ Required properties:
3535
bring the GPU out of secure mode.
3636
- firmware-name: optional property of the 'zap-shader' node, listing the
3737
relative path of the device specific zap firmware.
38+
- sram: phandle to the On Chip Memory (OCMEM) that's present on some a3xx and
39+
a4xx Snapdragon SoCs. See
40+
Documentation/devicetree/bindings/sram/qcom,ocmem.yaml.
3841

39-
Example 3xx/4xx/a5xx:
42+
Example 3xx/4xx:
4043

4144
/ {
4245
...
4346

44-
gpu: qcom,kgsl-3d0@4300000 {
45-
compatible = "qcom,adreno-320.2", "qcom,adreno";
46-
reg = <0x04300000 0x20000>;
47+
gpu: adreno@fdb00000 {
48+
compatible = "qcom,adreno-330.2",
49+
"qcom,adreno";
50+
reg = <0xfdb00000 0x10000>;
4751
reg-names = "kgsl_3d0_reg_memory";
48-
interrupts = <GIC_SPI 80 0>;
49-
clock-names =
50-
"core",
51-
"iface",
52-
"mem_iface";
53-
clocks =
54-
<&mmcc GFX3D_CLK>,
55-
<&mmcc GFX3D_AHB_CLK>,
56-
<&mmcc MMSS_IMEM_AHB_CLK>;
52+
interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
53+
interrupt-names = "kgsl_3d0_irq";
54+
clock-names = "core",
55+
"iface",
56+
"mem_iface";
57+
clocks = <&mmcc OXILI_GFX3D_CLK>,
58+
<&mmcc OXILICX_AHB_CLK>,
59+
<&mmcc OXILICX_AXI_CLK>;
60+
sram = <&gpu_sram>;
61+
power-domains = <&mmcc OXILICX_GDSC>;
62+
operating-points-v2 = <&gpu_opp_table>;
63+
iommus = <&gpu_iommu 0>;
64+
};
65+
66+
gpu_sram: ocmem@fdd00000 {
67+
compatible = "qcom,msm8974-ocmem";
68+
69+
reg = <0xfdd00000 0x2000>,
70+
<0xfec00000 0x180000>;
71+
reg-names = "ctrl",
72+
"mem";
73+
74+
clocks = <&rpmcc RPM_SMD_OCMEMGX_CLK>,
75+
<&mmcc OCMEMCX_OCMEMNOC_CLK>;
76+
clock-names = "core",
77+
"iface";
78+
79+
#address-cells = <1>;
80+
#size-cells = <1>;
81+
82+
gpu_sram: gpu-sram@0 {
83+
reg = <0x0 0x100000>;
84+
ranges = <0 0 0xfec00000 0x100000>;
85+
};
5786
};
5887
};
5988

0 commit comments

Comments
 (0)