Skip to content

Commit 00d9597

Browse files
mrutland-armctmarinas
authored andcommitted
arm64: pt_regs: rename "pmr_save" -> "pmr"
The pt_regs::pmr_save field is weirdly named relative to all other pt_regs fields, with a '_save' suffix that doesn't make anything clearer and only leads to more typing to access the field. Remove the '_save' suffix. There should be no functional change as a result of this patch. Signed-off-by: Mark Rutland <[email protected]> Reviewed-by: Mark Brown <[email protected]> Reviewed-by: Miroslav Benes <[email protected]> Reviewed-by: Puranjay Mohan <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Josh Poimboeuf <[email protected]> Cc: Kalesh Singh <[email protected]> Cc: Madhavan T. Venkataraman <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: Will Deacon <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Catalin Marinas <[email protected]>
1 parent 2716d59 commit 00d9597

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

arch/arm64/include/asm/daifflags.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ static inline void local_daif_inherit(struct pt_regs *regs)
132132
trace_hardirqs_on();
133133

134134
if (system_uses_irq_prio_masking())
135-
gic_write_pmr(regs->pmr_save);
135+
gic_write_pmr(regs->pmr);
136136

137137
/*
138138
* We can't use local_daif_restore(regs->pstate) here as

arch/arm64/include/asm/processor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ static inline void start_thread_common(struct pt_regs *regs, unsigned long pc)
293293
regs->pc = pc;
294294

295295
if (system_uses_irq_prio_masking())
296-
regs->pmr_save = GIC_PRIO_IRQON;
296+
regs->pmr = GIC_PRIO_IRQON;
297297
}
298298

299299
static inline void start_thread(struct pt_regs *regs, unsigned long pc,

arch/arm64/include/asm/ptrace.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ struct pt_regs {
167167

168168
u64 sdei_ttbr1;
169169
/* Only valid when ARM64_HAS_GIC_PRIO_MASKING is enabled. */
170-
u64 pmr_save;
170+
u64 pmr;
171171
u64 stackframe[2];
172172

173173
/* Only valid for some EL1 exceptions. */
@@ -211,7 +211,7 @@ static inline void forget_syscall(struct pt_regs *regs)
211211

212212
#define irqs_priority_unmasked(regs) \
213213
(system_uses_irq_prio_masking() ? \
214-
(regs)->pmr_save == GIC_PRIO_IRQON : \
214+
(regs)->pmr == GIC_PRIO_IRQON : \
215215
true)
216216

217217
#define interrupts_enabled(regs) \

arch/arm64/kernel/asm-offsets.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ int main(void)
7979
DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
8080
DEFINE(S_SYSCALLNO, offsetof(struct pt_regs, syscallno));
8181
DEFINE(S_SDEI_TTBR1, offsetof(struct pt_regs, sdei_ttbr1));
82-
DEFINE(S_PMR_SAVE, offsetof(struct pt_regs, pmr_save));
82+
DEFINE(S_PMR, offsetof(struct pt_regs, pmr));
8383
DEFINE(S_STACKFRAME, offsetof(struct pt_regs, stackframe));
8484
DEFINE(PT_REGS_SIZE, sizeof(struct pt_regs));
8585
BLANK();

arch/arm64/kernel/entry.S

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ alternative_if_not ARM64_HAS_GIC_PRIO_MASKING
315315
alternative_else_nop_endif
316316

317317
mrs_s x20, SYS_ICC_PMR_EL1
318-
str x20, [sp, #S_PMR_SAVE]
318+
str x20, [sp, #S_PMR]
319319
mov x20, #GIC_PRIO_IRQON | GIC_PRIO_PSR_I_SET
320320
msr_s SYS_ICC_PMR_EL1, x20
321321

@@ -342,7 +342,7 @@ alternative_if_not ARM64_HAS_GIC_PRIO_MASKING
342342
b .Lskip_pmr_restore\@
343343
alternative_else_nop_endif
344344

345-
ldr x20, [sp, #S_PMR_SAVE]
345+
ldr x20, [sp, #S_PMR]
346346
msr_s SYS_ICC_PMR_EL1, x20
347347

348348
/* Ensure priority change is seen by redistributor */

arch/arm64/kernel/process.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ void __show_regs(struct pt_regs *regs)
227227
printk("sp : %016llx\n", sp);
228228

229229
if (system_uses_irq_prio_masking())
230-
printk("pmr_save: %08llx\n", regs->pmr_save);
230+
printk("pmr: %08llx\n", regs->pmr);
231231

232232
i = top_reg;
233233

0 commit comments

Comments
 (0)