Skip to content

Commit 00eb74e

Browse files
LuBaolugregkh
authored andcommitted
driver core: Make bus notifiers in right order in really_probe()
If a driver cannot be bound to a device, the correct bus notifier order should be: - BUS_NOTIFY_BIND_DRIVER: driver is about to be bound - BUS_NOTIFY_DRIVER_NOT_BOUND: driver failed to be bound or no notifier if the failure happens before the actual binding. The really_probe() notifies a BUS_NOTIFY_DRIVER_NOT_BOUND event without a BUS_NOTIFY_BIND_DRIVER if .dma_configure() returns failure. This change makes the notifiers in order. Signed-off-by: Lu Baolu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 885e502 commit 00eb74e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/base/dd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,7 @@ static int really_probe(struct device *dev, struct device_driver *drv)
577577
if (dev->bus->dma_configure) {
578578
ret = dev->bus->dma_configure(dev);
579579
if (ret)
580-
goto sysfs_failed;
580+
goto pinctrl_bind_failed;
581581
}
582582

583583
ret = driver_sysfs_add(dev);

0 commit comments

Comments
 (0)