Skip to content

Commit 0100f67

Browse files
author
Greg Ungerer
committed
m68knommu: improve config ROM setting defaults
The ROM region configuration settings used on some nommu m68k systems (historically mostly 68328 (Dragonball) CPUs) default to an address of 0. That can easily clash with default RAM address settings which also default to 0. Of course that is invalid and those ranges overlap, but if you make no value selection that is what you end up with. Those default values produce a valid configuration but will fail compilation like this: m68k-linux-ld: section .rodata VMA [0000000000001000,0000000000262227] overlaps section .text VMA [0000000000000400,0000000000455e7f] Looking at the platforms that use the ROM region configuration settings it is clear that we can choose much better defaults than 0. By far the most common ROM region settings are these: CONFIG_ROMVEC=0x10c10000 CONFIG_ROMSTART=0x10c10400 So lets make these the default values. It is still possible to configure overlapping ROM and RAM regions, but at least the default selections are now valid. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Greg Ungerer <[email protected]>
1 parent 05d3ef8 commit 0100f67

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/m68k/Kconfig.machine

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ config ROM
441441

442442
config ROMVEC
443443
hex "Address of the base of the ROM vectors"
444-
default "0"
444+
default "0x10c10000"
445445
depends on ROM
446446
help
447447
This is almost always the same as the base of the ROM. Since on all
@@ -450,7 +450,7 @@ config ROMVEC
450450

451451
config ROMSTART
452452
hex "Address of the base of system image in ROM"
453-
default "0x400"
453+
default "0x10c10400"
454454
depends on ROM
455455
help
456456
Define the start address of the system image in ROM. Commonly this

0 commit comments

Comments
 (0)