Skip to content

Commit 012b827

Browse files
spectrum70jic23
authored andcommitted
iio: dac: ad3552r-hs: clear reset status flag
Clear reset status flag, to keep error status register clean after reset (ad3552r manual, rev B table 38). Reset error flag was left to 1, so debugging registers, the "Error Status Register" was dirty (0x01). It is important to clear this bit, so if there is any reset event over normal working mode, it is possible to detect it. Fixes: 0b4d9fe ("iio: dac: ad3552r: add high-speed platform driver") Signed-off-by: Angelo Dureghello <[email protected]> Reviewed-by: David Lechner <[email protected]> Link: https://patch.msgid.link/20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-2-2dac02f04638@baylibre.com Cc: <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 1e758b6 commit 012b827

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/iio/dac/ad3552r-hs.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,12 @@ static int ad3552r_hs_setup(struct ad3552r_hs_state *st)
329329
dev_info(st->dev, "Chip ID error. Expected 0x%x, Read 0x%x\n",
330330
AD3552R_ID, id);
331331

332+
/* Clear reset error flag, see ad3552r manual, rev B table 38. */
333+
ret = st->data->bus_reg_write(st->back, AD3552R_REG_ADDR_ERR_STATUS,
334+
AD3552R_MASK_RESET_STATUS, 1);
335+
if (ret)
336+
return ret;
337+
332338
ret = st->data->bus_reg_write(st->back,
333339
AD3552R_REG_ADDR_SH_REFERENCE_CONFIG,
334340
0, 1);

0 commit comments

Comments
 (0)