Skip to content

Commit 0139234

Browse files
Dan Carpenterdamien-lemoal
authored andcommitted
pata_legacy: fix a couple uninitialized variable bugs
The last byte of "pad" is used without being initialized. Fixes: 55dba31 ("libata: update ->data_xfer hook for ATAPI") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent 64570fb commit 0139234

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/ata/pata_legacy.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,8 @@ static unsigned int pdc_data_xfer_vlb(struct ata_queued_cmd *qc,
352352
iowrite32_rep(ap->ioaddr.data_addr, buf, buflen >> 2);
353353

354354
if (unlikely(slop)) {
355-
__le32 pad;
355+
__le32 pad = 0;
356+
356357
if (rw == READ) {
357358
pad = cpu_to_le32(ioread32(ap->ioaddr.data_addr));
358359
memcpy(buf + buflen - slop, &pad, slop);
@@ -742,7 +743,8 @@ static unsigned int vlb32_data_xfer(struct ata_queued_cmd *qc,
742743
ioread32_rep(ap->ioaddr.data_addr, buf, buflen >> 2);
743744

744745
if (unlikely(slop)) {
745-
__le32 pad;
746+
__le32 pad = 0;
747+
746748
if (rw == WRITE) {
747749
memcpy(&pad, buf + buflen - slop, slop);
748750
iowrite32(le32_to_cpu(pad), ap->ioaddr.data_addr);

0 commit comments

Comments
 (0)