Skip to content

Commit 0170857

Browse files
committed
drm/i915/ddi: 128b/132b SST also needs DP_TP_CTL_MODE_MST
It's not very clearly specified, and the hardware bit is ill-named, but 128b/132b SST also needs the MST mode set in the DP_TP_CTL register. This is preparation for enabling 128b/132b SST. This path is not reachable yet. Reviewed-by: Imre Deak <[email protected]> Signed-off-by: Jani Nikula <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/b29fbba8c979a8bab2bf03088610fe408faaf704.1735912293.git.jani.nikula@intel.com
1 parent 2f82724 commit 0170857

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/gpu/drm/i915/display/intel_ddi.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3655,7 +3655,8 @@ static void mtl_ddi_prepare_link_retrain(struct intel_dp *intel_dp,
36553655

36563656
/* 6.d Configure and enable DP_TP_CTL with link training pattern 1 selected */
36573657
dp_tp_ctl = DP_TP_CTL_ENABLE | DP_TP_CTL_LINK_TRAIN_PAT1;
3658-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) {
3658+
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST) ||
3659+
intel_dp_is_uhbr(crtc_state)) {
36593660
dp_tp_ctl |= DP_TP_CTL_MODE_MST;
36603661
} else {
36613662
dp_tp_ctl |= DP_TP_CTL_MODE_SST;
@@ -3715,7 +3716,8 @@ static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp,
37153716
}
37163717

37173718
dp_tp_ctl = DP_TP_CTL_ENABLE | DP_TP_CTL_LINK_TRAIN_PAT1;
3718-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) {
3719+
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST) ||
3720+
intel_dp_is_uhbr(crtc_state)) {
37193721
dp_tp_ctl |= DP_TP_CTL_MODE_MST;
37203722
} else {
37213723
dp_tp_ctl |= DP_TP_CTL_MODE_SST;

0 commit comments

Comments
 (0)