Skip to content

Commit 025af39

Browse files
lucaceresoliKAGA-KOKO
authored andcommitted
genirq: Show irq name in non-oneshot error message
Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the error message does not include the IRQ line name, which makes it harder to find the offending driver. Print the IRQ line name to clarify where the error comes from. Use the same format as the other pr_err() above in the same function. Signed-off-by: Luca Ceresoli <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent c79f46a commit 025af39

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/irq/manage.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
15001500
* has. The type flags are unreliable as the
15011501
* underlying chip implementation can override them.
15021502
*/
1503-
pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n",
1504-
irq);
1503+
pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
1504+
new->name, irq);
15051505
ret = -EINVAL;
15061506
goto out_unlock;
15071507
}

0 commit comments

Comments
 (0)