Skip to content

Commit 02782f3

Browse files
Sai Prakash Ranjanwilldeacon
authored andcommitted
iommu/arm-smmu: Make remove callback message more informative
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback. On SC7180: arm-smmu 15000000.iommu: removing device with active domains! arm-smmu 5040000.iommu: removing device with active domains! Make this error message more informative and less scary. Reported-by: Douglas Anderson <[email protected]> Suggested-by: Robin Murphy <[email protected]> Signed-off-by: Sai Prakash Ranjan <[email protected]> Reviewed-by: Douglas Anderson <[email protected]> Link: https://lore.kernel.org/r/[email protected] [will: use dev_notice() as per Robin] Signed-off-by: Will Deacon <[email protected]>
1 parent 1b032ec commit 02782f3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iommu/arm-smmu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2244,7 +2244,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
22442244
return -ENODEV;
22452245

22462246
if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS))
2247-
dev_err(&pdev->dev, "removing device with active domains!\n");
2247+
dev_notice(&pdev->dev, "disabling translation\n");
22482248

22492249
arm_smmu_bus_init(NULL);
22502250
iommu_device_unregister(&smmu->iommu);

0 commit comments

Comments
 (0)