Skip to content

Commit 02a06f5

Browse files
committed
PCI/AER: Use 'Correctable' and 'Uncorrectable' spec terms for errors
The PCIe spec classifies errors as either "Correctable" or "Uncorrectable". Previously we printed these as "Corrected" or "Uncorrected". To avoid confusion, use the same terms as the spec. One confusing situation is when one agent detects an error, but another agent is responsible for recovery, e.g., by re-attempting the operation. The first agent may log a "correctable" error but it has not yet been corrected. The recovery agent must report an uncorrectable error if it is unable to recover. If we print the first agent's error as "Corrected", it gives the false impression that it has already been resolved. Sample message change: - pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 + pcieport 0000:00:1c.5: AER: Correctable error received: 0000:00:1c.5 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>
1 parent b85ea95 commit 02a06f5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/pci/pcie/aer.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,10 +435,10 @@ void pci_aer_exit(struct pci_dev *dev)
435435
/*
436436
* AER error strings
437437
*/
438-
static const char *aer_error_severity_string[] = {
439-
"Uncorrected (Non-Fatal)",
440-
"Uncorrected (Fatal)",
441-
"Corrected"
438+
static const char * const aer_error_severity_string[] = {
439+
"Uncorrectable (Non-Fatal)",
440+
"Uncorrectable (Fatal)",
441+
"Correctable"
442442
};
443443

444444
static const char *aer_error_layer[] = {

0 commit comments

Comments
 (0)