Skip to content

Commit 02cd2d3

Browse files
Tom Rixsravnborg
authored andcommitted
drm/bridge: sil_sii8620: initialize return of sii8620_readb
clang static analysis flags this error sil-sii8620.c:184:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~~~~~~~~~ sii8620_readb calls sii8620_read_buf. sii8620_read_buf can return without setting its output pararmeter 'ret'. So initialize ret. Fixes: ce6e153 ("drm/bridge: add Silicon Image SiI8620 driver") Signed-off-by: Tom Rix <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Reviewed-by: Andrzej Hajda <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 1e691e2 commit 02cd2d3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/bridge/sil-sii8620.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len)
178178

179179
static u8 sii8620_readb(struct sii8620 *ctx, u16 addr)
180180
{
181-
u8 ret;
181+
u8 ret = 0;
182182

183183
sii8620_read_buf(ctx, addr, &ret, 1);
184184
return ret;

0 commit comments

Comments
 (0)