Skip to content

Commit 03264dd

Browse files
AdamWillmartinkpetersen
authored andcommitted
scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places
Arnd Bergmann inadvertently typoed these in d320a95 and 64cbfa9; they seem to be the cause of https://bugzilla.redhat.com/show_bug.cgi?id=1801353 , invalid SCSI commands when udev tries to query a DVD drive. [arnd] Found another instance of the same bug, also introduced in my compat_ioctl series. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1801353 Link: https://lore.kernel.org/r/[email protected] Fixes: c103d6e ("compat_ioctl: ide: floppy: add handler") Fixes: 64cbfa9 ("compat_ioctl: move cdrom commands into cdrom.c") Fixes: d320a95 ("compat_ioctl: scsi: move ioctl handling into drivers") Bisected-by: Chris Murphy <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Adam Williamson <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent a3fd4bf commit 03264dd

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

drivers/block/paride/pcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ static const struct block_device_operations pcd_bdops = {
276276
.release = pcd_block_release,
277277
.ioctl = pcd_block_ioctl,
278278
#ifdef CONFIG_COMPAT
279-
.ioctl = blkdev_compat_ptr_ioctl,
279+
.compat_ioctl = blkdev_compat_ptr_ioctl,
280280
#endif
281281
.check_events = pcd_block_check_events,
282282
};

drivers/cdrom/gdrom.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ static const struct block_device_operations gdrom_bdops = {
519519
.check_events = gdrom_bdops_check_events,
520520
.ioctl = gdrom_bdops_ioctl,
521521
#ifdef CONFIG_COMPAT
522-
.ioctl = blkdev_compat_ptr_ioctl,
522+
.compat_ioctl = blkdev_compat_ptr_ioctl,
523523
#endif
524524
};
525525

drivers/ide/ide-gd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ static const struct block_device_operations ide_gd_ops = {
361361
.release = ide_gd_release,
362362
.ioctl = ide_gd_ioctl,
363363
#ifdef CONFIG_COMPAT
364-
.ioctl = ide_gd_compat_ioctl,
364+
.compat_ioctl = ide_gd_compat_ioctl,
365365
#endif
366366
.getgeo = ide_gd_getgeo,
367367
.check_events = ide_gd_check_events,

drivers/scsi/sr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,7 @@ static const struct block_device_operations sr_bdops =
688688
.release = sr_block_release,
689689
.ioctl = sr_block_ioctl,
690690
#ifdef CONFIG_COMPAT
691-
.ioctl = sr_block_compat_ioctl,
691+
.compat_ioctl = sr_block_compat_ioctl,
692692
#endif
693693
.check_events = sr_block_check_events,
694694
.revalidate_disk = sr_block_revalidate_disk,

0 commit comments

Comments
 (0)