HID: roccat: Convert sprintf() family to sysfs_emit() family

zhijianli88 · Jiri Kosina · commit 0336d4e997a0 · 2024-04-03T13:42:04.000+02:00
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() and scnprintf() will be converted as well if they have.

Generally, this patch is generated by
make coccicheck M=&lt;path/to/file&gt; MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Stefan Achatz &lt;erazor_de@users.sourceforge.net&gt;
CC: Jiri Kosina &lt;jikos@kernel.org&gt;
CC: Benjamin Tissoires &lt;benjamin.tissoires@redhat.com&gt;
CC: linux-input@vger.kernel.org
Signed-off-by: Li Zhijian &lt;lizhijian@fujitsu.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.com&gt;
diff --git a/drivers/hid/hid-roccat-isku.c b/drivers/hid/hid-roccat-isku.c
@@ -61,7 +61,7 @@ static ssize_t isku_sysfs_show_actual_profile(struct device *dev,
 {
 	struct isku_device *isku =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", isku->actual_profile);
+	return sysfs_emit(buf, "%d\n", isku->actual_profile);
 }
 
 static ssize_t isku_sysfs_set_actual_profile(struct device *dev,
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
@@ -400,7 +400,7 @@ static ssize_t kone_sysfs_show_actual_profile(struct device *dev,
 {
 	struct kone_device *kone =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kone->actual_profile);
+	return sysfs_emit(buf, "%d\n", kone->actual_profile);
 }
 static DEVICE_ATTR(actual_profile, 0440, kone_sysfs_show_actual_profile, NULL);
 
@@ -409,7 +409,7 @@ static ssize_t kone_sysfs_show_actual_dpi(struct device *dev,
 {
 	struct kone_device *kone =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kone->actual_dpi);
+	return sysfs_emit(buf, "%d\n", kone->actual_dpi);
 }
 static DEVICE_ATTR(actual_dpi, 0440, kone_sysfs_show_actual_dpi, NULL);
 
@@ -432,7 +432,7 @@ static ssize_t kone_sysfs_show_weight(struct device *dev,
 
 	if (retval)
 		return retval;
-	return snprintf(buf, PAGE_SIZE, "%d\n", weight);
+	return sysfs_emit(buf, "%d\n", weight);
 }
 static DEVICE_ATTR(weight, 0440, kone_sysfs_show_weight, NULL);
 
@@ -441,7 +441,7 @@ static ssize_t kone_sysfs_show_firmware_version(struct device *dev,
 {
 	struct kone_device *kone =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kone->firmware_version);
+	return sysfs_emit(buf, "%d\n", kone->firmware_version);
 }
 static DEVICE_ATTR(firmware_version, 0440, kone_sysfs_show_firmware_version,
 		   NULL);
@@ -451,7 +451,7 @@ static ssize_t kone_sysfs_show_tcu(struct device *dev,
 {
 	struct kone_device *kone =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kone->settings.tcu);
+	return sysfs_emit(buf, "%d\n", kone->settings.tcu);
 }
 
 static int kone_tcu_command(struct usb_device *usb_dev, int number)
@@ -553,7 +553,7 @@ static ssize_t kone_sysfs_show_startup_profile(struct device *dev,
 {
 	struct kone_device *kone =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kone->settings.startup_profile);
+	return sysfs_emit(buf, "%d\n", kone->settings.startup_profile);
 }
 
 static ssize_t kone_sysfs_set_startup_profile(struct device *dev,
diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c
@@ -242,7 +242,7 @@ static ssize_t koneplus_sysfs_show_actual_profile(struct device *dev,
 {
 	struct koneplus_device *koneplus =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", koneplus->actual_profile);
+	return sysfs_emit(buf, "%d\n", koneplus->actual_profile);
 }
 
 static ssize_t koneplus_sysfs_set_actual_profile(struct device *dev,
@@ -309,7 +309,7 @@ static ssize_t koneplus_sysfs_show_firmware_version(struct device *dev,
 			&info, KONEPLUS_SIZE_INFO);
 	mutex_unlock(&koneplus->koneplus_lock);
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);
+	return sysfs_emit(buf, "%d\n", info.firmware_version);
 }
 static DEVICE_ATTR(firmware_version, 0440,
 		   koneplus_sysfs_show_firmware_version, NULL);
diff --git a/drivers/hid/hid-roccat-kovaplus.c b/drivers/hid/hid-roccat-kovaplus.c
@@ -272,7 +272,7 @@ static ssize_t kovaplus_sysfs_show_actual_profile(struct device *dev,
 {
 	struct kovaplus_device *kovaplus =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_profile);
+	return sysfs_emit(buf, "%d\n", kovaplus->actual_profile);
 }
 
 static ssize_t kovaplus_sysfs_set_actual_profile(struct device *dev,
@@ -325,7 +325,7 @@ static ssize_t kovaplus_sysfs_show_actual_cpi(struct device *dev,
 {
 	struct kovaplus_device *kovaplus =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_cpi);
+	return sysfs_emit(buf, "%d\n", kovaplus->actual_cpi);
 }
 static DEVICE_ATTR(actual_cpi, 0440, kovaplus_sysfs_show_actual_cpi, NULL);
 
@@ -334,7 +334,7 @@ static ssize_t kovaplus_sysfs_show_actual_sensitivity_x(struct device *dev,
 {
 	struct kovaplus_device *kovaplus =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_x_sensitivity);
+	return sysfs_emit(buf, "%d\n", kovaplus->actual_x_sensitivity);
 }
 static DEVICE_ATTR(actual_sensitivity_x, 0440,
 		   kovaplus_sysfs_show_actual_sensitivity_x, NULL);
@@ -344,7 +344,7 @@ static ssize_t kovaplus_sysfs_show_actual_sensitivity_y(struct device *dev,
 {
 	struct kovaplus_device *kovaplus =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_y_sensitivity);
+	return sysfs_emit(buf, "%d\n", kovaplus->actual_y_sensitivity);
 }
 static DEVICE_ATTR(actual_sensitivity_y, 0440,
 		   kovaplus_sysfs_show_actual_sensitivity_y, NULL);
@@ -365,7 +365,7 @@ static ssize_t kovaplus_sysfs_show_firmware_version(struct device *dev,
 			&info, KOVAPLUS_SIZE_INFO);
 	mutex_unlock(&kovaplus->kovaplus_lock);
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);
+	return sysfs_emit(buf, "%d\n", info.firmware_version);
 }
 static DEVICE_ATTR(firmware_version, 0440,
 		   kovaplus_sysfs_show_firmware_version, NULL);
diff --git a/drivers/hid/hid-roccat-pyra.c b/drivers/hid/hid-roccat-pyra.c
@@ -283,7 +283,7 @@ static ssize_t pyra_sysfs_show_actual_cpi(struct device *dev,
 {
 	struct pyra_device *pyra =
 			hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-	return snprintf(buf, PAGE_SIZE, "%d\n", pyra->actual_cpi);
+	return sysfs_emit(buf, "%d\n", pyra->actual_cpi);
 }
 static DEVICE_ATTR(actual_cpi, 0440, pyra_sysfs_show_actual_cpi, NULL);
 
@@ -300,7 +300,7 @@ static ssize_t pyra_sysfs_show_actual_profile(struct device *dev,
 			&settings, PYRA_SIZE_SETTINGS);
 	mutex_unlock(&pyra->pyra_lock);
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", settings.startup_profile);
+	return sysfs_emit(buf, "%d\n", settings.startup_profile);
 }
 static DEVICE_ATTR(actual_profile, 0440, pyra_sysfs_show_actual_profile, NULL);
 static DEVICE_ATTR(startup_profile, 0440, pyra_sysfs_show_actual_profile, NULL);
@@ -321,7 +321,7 @@ static ssize_t pyra_sysfs_show_firmware_version(struct device *dev,
 			&info, PYRA_SIZE_INFO);
 	mutex_unlock(&pyra->pyra_lock);
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);
+	return sysfs_emit(buf, "%d\n", info.firmware_version);
 }
 static DEVICE_ATTR(firmware_version, 0440, pyra_sysfs_show_firmware_version,
 		   NULL);

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ static ssize_t isku_sysfs_show_actual_profile(struct device *dev,`
`61`	`61`	`{`
`62`	`62`	`struct isku_device *isku =`
`63`	`63`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`64`		`- return snprintf(buf, PAGE_SIZE, "%d\n", isku->actual_profile);`
	`64`	`+ return sysfs_emit(buf, "%d\n", isku->actual_profile);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`static ssize_t isku_sysfs_set_actual_profile(struct device *dev,`
Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,7 @@ static ssize_t kone_sysfs_show_actual_profile(struct device *dev,`
`400`	`400`	`{`
`401`	`401`	`struct kone_device *kone =`
`402`	`402`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`403`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kone->actual_profile);`
	`403`	`+ return sysfs_emit(buf, "%d\n", kone->actual_profile);`
`404`	`404`	`}`
`405`	`405`	`static DEVICE_ATTR(actual_profile, 0440, kone_sysfs_show_actual_profile, NULL);`
`406`	`406`
`@@ -409,7 +409,7 @@ static ssize_t kone_sysfs_show_actual_dpi(struct device *dev,`
`409`	`409`	`{`
`410`	`410`	`struct kone_device *kone =`
`411`	`411`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`412`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kone->actual_dpi);`
	`412`	`+ return sysfs_emit(buf, "%d\n", kone->actual_dpi);`
`413`	`413`	`}`
`414`	`414`	`static DEVICE_ATTR(actual_dpi, 0440, kone_sysfs_show_actual_dpi, NULL);`
`415`	`415`
`@@ -432,7 +432,7 @@ static ssize_t kone_sysfs_show_weight(struct device *dev,`
`432`	`432`
`433`	`433`	`if (retval)`
`434`	`434`	`return retval;`
`435`		`- return snprintf(buf, PAGE_SIZE, "%d\n", weight);`
	`435`	`+ return sysfs_emit(buf, "%d\n", weight);`
`436`	`436`	`}`
`437`	`437`	`static DEVICE_ATTR(weight, 0440, kone_sysfs_show_weight, NULL);`
`438`	`438`
`@@ -441,7 +441,7 @@ static ssize_t kone_sysfs_show_firmware_version(struct device *dev,`
`441`	`441`	`{`
`442`	`442`	`struct kone_device *kone =`
`443`	`443`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`444`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kone->firmware_version);`
	`444`	`+ return sysfs_emit(buf, "%d\n", kone->firmware_version);`
`445`	`445`	`}`
`446`	`446`	`static DEVICE_ATTR(firmware_version, 0440, kone_sysfs_show_firmware_version,`
`447`	`447`	`NULL);`
`@@ -451,7 +451,7 @@ static ssize_t kone_sysfs_show_tcu(struct device *dev,`
`451`	`451`	`{`
`452`	`452`	`struct kone_device *kone =`
`453`	`453`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`454`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kone->settings.tcu);`
	`454`	`+ return sysfs_emit(buf, "%d\n", kone->settings.tcu);`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`static int kone_tcu_command(struct usb_device *usb_dev, int number)`
`@@ -553,7 +553,7 @@ static ssize_t kone_sysfs_show_startup_profile(struct device *dev,`
`553`	`553`	`{`
`554`	`554`	`struct kone_device *kone =`
`555`	`555`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`556`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kone->settings.startup_profile);`
	`556`	`+ return sysfs_emit(buf, "%d\n", kone->settings.startup_profile);`
`557`	`557`	`}`
`558`	`558`
`559`	`559`	`static ssize_t kone_sysfs_set_startup_profile(struct device *dev,`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ static ssize_t koneplus_sysfs_show_actual_profile(struct device *dev,`
`242`	`242`	`{`
`243`	`243`	`struct koneplus_device *koneplus =`
`244`	`244`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`245`		`- return snprintf(buf, PAGE_SIZE, "%d\n", koneplus->actual_profile);`
	`245`	`+ return sysfs_emit(buf, "%d\n", koneplus->actual_profile);`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`static ssize_t koneplus_sysfs_set_actual_profile(struct device *dev,`
`@@ -309,7 +309,7 @@ static ssize_t koneplus_sysfs_show_firmware_version(struct device *dev,`
`309`	`309`	`&info, KONEPLUS_SIZE_INFO);`
`310`	`310`	`mutex_unlock(&koneplus->koneplus_lock);`
`311`	`311`
`312`		`- return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);`
	`312`	`+ return sysfs_emit(buf, "%d\n", info.firmware_version);`
`313`	`313`	`}`
`314`	`314`	`static DEVICE_ATTR(firmware_version, 0440,`
`315`	`315`	`koneplus_sysfs_show_firmware_version, NULL);`
Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ static ssize_t kovaplus_sysfs_show_actual_profile(struct device *dev,`
`272`	`272`	`{`
`273`	`273`	`struct kovaplus_device *kovaplus =`
`274`	`274`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`275`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_profile);`
	`275`	`+ return sysfs_emit(buf, "%d\n", kovaplus->actual_profile);`
`276`	`276`	`}`
`277`	`277`
`278`	`278`	`static ssize_t kovaplus_sysfs_set_actual_profile(struct device *dev,`
`@@ -325,7 +325,7 @@ static ssize_t kovaplus_sysfs_show_actual_cpi(struct device *dev,`
`325`	`325`	`{`
`326`	`326`	`struct kovaplus_device *kovaplus =`
`327`	`327`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`328`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_cpi);`
	`328`	`+ return sysfs_emit(buf, "%d\n", kovaplus->actual_cpi);`
`329`	`329`	`}`
`330`	`330`	`static DEVICE_ATTR(actual_cpi, 0440, kovaplus_sysfs_show_actual_cpi, NULL);`
`331`	`331`
`@@ -334,7 +334,7 @@ static ssize_t kovaplus_sysfs_show_actual_sensitivity_x(struct device *dev,`
`334`	`334`	`{`
`335`	`335`	`struct kovaplus_device *kovaplus =`
`336`	`336`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`337`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_x_sensitivity);`
	`337`	`+ return sysfs_emit(buf, "%d\n", kovaplus->actual_x_sensitivity);`
`338`	`338`	`}`
`339`	`339`	`static DEVICE_ATTR(actual_sensitivity_x, 0440,`
`340`	`340`	`kovaplus_sysfs_show_actual_sensitivity_x, NULL);`
`@@ -344,7 +344,7 @@ static ssize_t kovaplus_sysfs_show_actual_sensitivity_y(struct device *dev,`
`344`	`344`	`{`
`345`	`345`	`struct kovaplus_device *kovaplus =`
`346`	`346`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`347`		`- return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_y_sensitivity);`
	`347`	`+ return sysfs_emit(buf, "%d\n", kovaplus->actual_y_sensitivity);`
`348`	`348`	`}`
`349`	`349`	`static DEVICE_ATTR(actual_sensitivity_y, 0440,`
`350`	`350`	`kovaplus_sysfs_show_actual_sensitivity_y, NULL);`
`@@ -365,7 +365,7 @@ static ssize_t kovaplus_sysfs_show_firmware_version(struct device *dev,`
`365`	`365`	`&info, KOVAPLUS_SIZE_INFO);`
`366`	`366`	`mutex_unlock(&kovaplus->kovaplus_lock);`
`367`	`367`
`368`		`- return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);`
	`368`	`+ return sysfs_emit(buf, "%d\n", info.firmware_version);`
`369`	`369`	`}`
`370`	`370`	`static DEVICE_ATTR(firmware_version, 0440,`
`371`	`371`	`kovaplus_sysfs_show_firmware_version, NULL);`
Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ static ssize_t pyra_sysfs_show_actual_cpi(struct device *dev,`
`283`	`283`	`{`
`284`	`284`	`struct pyra_device *pyra =`
`285`	`285`	`hid_get_drvdata(dev_get_drvdata(dev->parent->parent));`
`286`		`- return snprintf(buf, PAGE_SIZE, "%d\n", pyra->actual_cpi);`
	`286`	`+ return sysfs_emit(buf, "%d\n", pyra->actual_cpi);`
`287`	`287`	`}`
`288`	`288`	`static DEVICE_ATTR(actual_cpi, 0440, pyra_sysfs_show_actual_cpi, NULL);`
`289`	`289`
`@@ -300,7 +300,7 @@ static ssize_t pyra_sysfs_show_actual_profile(struct device *dev,`
`300`	`300`	`&settings, PYRA_SIZE_SETTINGS);`
`301`	`301`	`mutex_unlock(&pyra->pyra_lock);`
`302`	`302`
`303`		`- return snprintf(buf, PAGE_SIZE, "%d\n", settings.startup_profile);`
	`303`	`+ return sysfs_emit(buf, "%d\n", settings.startup_profile);`
`304`	`304`	`}`
`305`	`305`	`static DEVICE_ATTR(actual_profile, 0440, pyra_sysfs_show_actual_profile, NULL);`
`306`	`306`	`static DEVICE_ATTR(startup_profile, 0440, pyra_sysfs_show_actual_profile, NULL);`
`@@ -321,7 +321,7 @@ static ssize_t pyra_sysfs_show_firmware_version(struct device *dev,`
`321`	`321`	`&info, PYRA_SIZE_INFO);`
`322`	`322`	`mutex_unlock(&pyra->pyra_lock);`
`323`	`323`
`324`		`- return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);`
	`324`	`+ return sysfs_emit(buf, "%d\n", info.firmware_version);`
`325`	`325`	`}`
`326`	`326`	`static DEVICE_ATTR(firmware_version, 0440, pyra_sysfs_show_firmware_version,`
`327`	`327`	`NULL);`