Skip to content

Commit 033e808

Browse files
committed
Merge tag 'block-6.9-20240329' of git://git.kernel.dk/linux
Pull block fixes from Jens Axboe: "Small round of minor fixes or cleanups for the 6.9-rc2 kernel, one fixing an issue introduced in 6.8" * tag 'block-6.9-20240329' of git://git.kernel.dk/linux: block: Do not force full zone append completion in req_bio_endio() block: don't reject too large max_user_sectors in blk_validate_limits block: Make blk_rq_set_mixed_merge() static
2 parents 3508f31 + 55251fb commit 033e808

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

block/blk-merge.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@ static int ll_merge_requests_fn(struct request_queue *q, struct request *req,
726726
* which can be mixed are set in each bio and mark @rq as mixed
727727
* merged.
728728
*/
729-
void blk_rq_set_mixed_merge(struct request *rq)
729+
static void blk_rq_set_mixed_merge(struct request *rq)
730730
{
731731
blk_opf_t ff = rq->cmd_flags & REQ_FAILFAST_MASK;
732732
struct bio *bio;

block/blk-mq.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -770,16 +770,11 @@ static void req_bio_endio(struct request *rq, struct bio *bio,
770770
/*
771771
* Partial zone append completions cannot be supported as the
772772
* BIO fragments may end up not being written sequentially.
773-
* For such case, force the completed nbytes to be equal to
774-
* the BIO size so that bio_advance() sets the BIO remaining
775-
* size to 0 and we end up calling bio_endio() before returning.
776773
*/
777-
if (bio->bi_iter.bi_size != nbytes) {
774+
if (bio->bi_iter.bi_size != nbytes)
778775
bio->bi_status = BLK_STS_IOERR;
779-
nbytes = bio->bi_iter.bi_size;
780-
} else {
776+
else
781777
bio->bi_iter.bi_sector = rq->__sector;
782-
}
783778
}
784779

785780
bio_advance(bio, nbytes);

block/blk-settings.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,7 @@ static int blk_validate_limits(struct queue_limits *lim)
146146
max_hw_sectors = min_not_zero(lim->max_hw_sectors,
147147
lim->max_dev_sectors);
148148
if (lim->max_user_sectors) {
149-
if (lim->max_user_sectors > max_hw_sectors ||
150-
lim->max_user_sectors < PAGE_SIZE / SECTOR_SIZE)
149+
if (lim->max_user_sectors < PAGE_SIZE / SECTOR_SIZE)
151150
return -EINVAL;
152151
lim->max_sectors = min(max_hw_sectors, lim->max_user_sectors);
153152
} else {

block/blk.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,6 @@ int ll_back_merge_fn(struct request *req, struct bio *bio,
339339
bool blk_attempt_req_merge(struct request_queue *q, struct request *rq,
340340
struct request *next);
341341
unsigned int blk_recalc_rq_segments(struct request *rq);
342-
void blk_rq_set_mixed_merge(struct request *rq);
343342
bool blk_rq_merge_ok(struct request *rq, struct bio *bio);
344343
enum elv_merge blk_try_merge(struct request *rq, struct bio *bio);
345344

0 commit comments

Comments
 (0)