Skip to content

Commit 03ab9cb

Browse files
dhowellssmfrench
authored andcommitted
cifs: Deal with some warnings from W=1
Deal with some warnings generated from make W=1: (1) Add/remove/fix kerneldoc parameters descriptions. (2) Turn cifs' rqst_page_get_length()'s banner comment into a kerneldoc comment. It should probably be prefixed with "cifs_" though. Signed-off-by: David Howells <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent e946d3c commit 03ab9cb

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

fs/cifs/misc.c

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,7 @@ void cifs_put_writer(struct cifsInodeInfo *cinode)
590590

591591
/**
592592
* cifs_queue_oplock_break - queue the oplock break handler for cfile
593+
* @cfile: The file to break the oplock on
593594
*
594595
* This function is called from the demultiplex thread when it
595596
* receives an oplock break for @cfile.
@@ -1065,6 +1066,9 @@ setup_aio_ctx_iter(struct cifs_aio_ctx *ctx, struct iov_iter *iter, int rw)
10651066

10661067
/**
10671068
* cifs_alloc_hash - allocate hash and hash context together
1069+
* @name: The name of the crypto hash algo
1070+
* @shash: Where to put the pointer to the hash algo
1071+
* @sdesc: Where to put the pointer to the hash descriptor
10681072
*
10691073
* The caller has to make sure @sdesc is initialized to either NULL or
10701074
* a valid context. Both can be freed via cifs_free_hash().
@@ -1103,6 +1107,8 @@ cifs_alloc_hash(const char *name,
11031107

11041108
/**
11051109
* cifs_free_hash - free hash and hash context together
1110+
* @shash: Where to find the pointer to the hash algo
1111+
* @sdesc: Where to find the pointer to the hash descriptor
11061112
*
11071113
* Freeing a NULL hash or context is safe.
11081114
*/
@@ -1118,8 +1124,10 @@ cifs_free_hash(struct crypto_shash **shash, struct sdesc **sdesc)
11181124

11191125
/**
11201126
* rqst_page_get_length - obtain the length and offset for a page in smb_rqst
1121-
* Input: rqst - a smb_rqst, page - a page index for rqst
1122-
* Output: *len - the length for this page, *offset - the offset for this page
1127+
* @rqst: The request descriptor
1128+
* @page: The index of the page to query
1129+
* @len: Where to store the length for this page:
1130+
* @offset: Where to store the offset for this page
11231131
*/
11241132
void rqst_page_get_length(struct smb_rqst *rqst, unsigned int page,
11251133
unsigned int *len, unsigned int *offset)
@@ -1152,6 +1160,8 @@ void extract_unc_hostname(const char *unc, const char **h, size_t *len)
11521160

11531161
/**
11541162
* copy_path_name - copy src path to dst, possibly truncating
1163+
* @dst: The destination buffer
1164+
* @src: The source name
11551165
*
11561166
* returns number of bytes written (including trailing nul)
11571167
*/

0 commit comments

Comments
 (0)