Skip to content

Commit 03dad2f

Browse files
committed
Merge tag 'sound-fix-6.2' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
Pull sound fixes from Takashi Iwai: "A few last-minute fixes. The significant ones are two ASoC SOF regression fixes while the rest are trivial HD-audio quirks. All are small / one-liners and should be pretty safe to take" * tag 'sound-fix-6.2' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak ALSA: hda/realtek: Enable mute/micmute LEDs and speaker support for HP Laptops ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform. ALSA: hda/realtek - fixed wrong gpio assigned ALSA: hda: Fix codec device field initializan ALSA: hda/conexant: add a new hda codec SN6180 ASoC: SOF: ops: refine parameters order in function snd_sof_dsp_update8
2 parents 4b89ca5 + e97fc9c commit 03dad2f

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

sound/pci/hda/hda_codec.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -927,7 +927,6 @@ snd_hda_codec_device_init(struct hda_bus *bus, unsigned int codec_addr,
927927
codec->depop_delay = -1;
928928
codec->fixup_id = HDA_FIXUP_ID_NOT_SET;
929929
codec->core.dev.release = snd_hda_codec_dev_release;
930-
codec->core.exec_verb = codec_exec_verb;
931930
codec->core.type = HDA_DEV_LEGACY;
932931

933932
mutex_init(&codec->spdif_mutex);
@@ -998,6 +997,7 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card,
998997
if (snd_BUG_ON(codec_addr > HDA_MAX_CODEC_ADDRESS))
999998
return -EINVAL;
1000999

1000+
codec->core.exec_verb = codec_exec_verb;
10011001
codec->card = card;
10021002
codec->addr = codec_addr;
10031003

sound/pci/hda/patch_conexant.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1125,6 +1125,7 @@ static const struct hda_device_id snd_hda_id_conexant[] = {
11251125
HDA_CODEC_ENTRY(0x14f11f87, "SN6140", patch_conexant_auto),
11261126
HDA_CODEC_ENTRY(0x14f12008, "CX8200", patch_conexant_auto),
11271127
HDA_CODEC_ENTRY(0x14f120d0, "CX11970", patch_conexant_auto),
1128+
HDA_CODEC_ENTRY(0x14f120d1, "SN6180", patch_conexant_auto),
11281129
HDA_CODEC_ENTRY(0x14f15045, "CX20549 (Venice)", patch_conexant_auto),
11291130
HDA_CODEC_ENTRY(0x14f15047, "CX20551 (Waikiki)", patch_conexant_auto),
11301131
HDA_CODEC_ENTRY(0x14f15051, "CX20561 (Hermosa)", patch_conexant_auto),

sound/pci/hda/patch_realtek.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -832,7 +832,7 @@ static int alc_subsystem_id(struct hda_codec *codec, const hda_nid_t *ports)
832832
alc_setup_gpio(codec, 0x02);
833833
break;
834834
case 7:
835-
alc_setup_gpio(codec, 0x03);
835+
alc_setup_gpio(codec, 0x04);
836836
break;
837837
case 5:
838838
default:
@@ -9432,10 +9432,17 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
94329432
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
94339433
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
94349434
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
9435+
SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
9436+
SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
9437+
SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
9438+
SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
9439+
SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
9440+
SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
94359441
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
94369442
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
94379443
SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
94389444
SND_PCI_QUIRK(0x103c, 0x8b7d, "HP", ALC236_FIXUP_HP_GPIO_LED),
9445+
SND_PCI_QUIRK(0x103c, 0x8b87, "HP", ALC236_FIXUP_HP_GPIO_LED),
94399446
SND_PCI_QUIRK(0x103c, 0x8b8a, "HP", ALC236_FIXUP_HP_GPIO_LED),
94409447
SND_PCI_QUIRK(0x103c, 0x8b8b, "HP", ALC236_FIXUP_HP_GPIO_LED),
94419448
SND_PCI_QUIRK(0x103c, 0x8b8d, "HP", ALC236_FIXUP_HP_GPIO_LED),

sound/soc/sof/intel/hda-dai.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@ static int hda_link_dma_hw_params(struct snd_pcm_substream *substream,
216216
sdev = snd_soc_component_get_drvdata(cpu_dai->component);
217217
bus = sof_to_bus(sdev);
218218

219+
hlink = snd_hdac_ext_bus_get_hlink_by_name(bus, codec_dai->component->name);
220+
if (!hlink)
221+
return -EINVAL;
222+
219223
hext_stream = snd_soc_dai_get_dma_data(cpu_dai, substream);
220224
if (!hext_stream) {
221225
hext_stream = hda_link_stream_assign(bus, substream);
@@ -225,10 +229,6 @@ static int hda_link_dma_hw_params(struct snd_pcm_substream *substream,
225229
snd_soc_dai_set_dma_data(cpu_dai, substream, (void *)hext_stream);
226230
}
227231

228-
hlink = snd_hdac_ext_bus_get_hlink_by_name(bus, codec_dai->component->name);
229-
if (!hlink)
230-
return -EINVAL;
231-
232232
/* set the hdac_stream in the codec dai */
233233
snd_soc_dai_set_stream(codec_dai, hdac_stream(hext_stream), substream->stream);
234234

sound/soc/sof/ops.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ static inline u64 snd_sof_dsp_read64(struct snd_sof_dev *sdev, u32 bar,
357357
}
358358

359359
static inline void snd_sof_dsp_update8(struct snd_sof_dev *sdev, u32 bar,
360-
u32 offset, u8 value, u8 mask)
360+
u32 offset, u8 mask, u8 value)
361361
{
362362
u8 reg;
363363

0 commit comments

Comments
 (0)