Skip to content

Commit 03f5eb3

Browse files
rddunlapjwrdegoede
authored andcommitted
platform: mellanox: select REGMAP instead of depending on it
REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". For NVSW_SN2201, select REGMAP_I2C instead of depending on it. Fixes: c6acad6 ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface") Fixes: 5ec4a8a ("platform/mellanox: Introduce support for Mellanox register access driver") Fixes: 62f9529 ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices") Fixes: 662f248 ("platform/mellanox: Add support for new SN2201 system") Signed-off-by: Randy Dunlap <[email protected]> Cc: Darren Hart <[email protected]> Cc: Hans de Goede <[email protected]> Cc: Michael Shych <[email protected]> Cc: Mark Gross <[email protected]> Cc: Vadim Pasternak <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Hans de Goede <[email protected]>
1 parent 6a192c0 commit 03f5eb3

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

drivers/platform/mellanox/Kconfig

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@ if MELLANOX_PLATFORM
1616

1717
config MLXREG_HOTPLUG
1818
tristate "Mellanox platform hotplug driver support"
19-
depends on REGMAP
2019
depends on HWMON
2120
depends on I2C
21+
select REGMAP
2222
help
2323
This driver handles hot-plug events for the power suppliers, power
2424
cables and fans on the wide range Mellanox IB and Ethernet systems.
2525

2626
config MLXREG_IO
2727
tristate "Mellanox platform register access driver support"
28-
depends on REGMAP
2928
depends on HWMON
29+
select REGMAP
3030
help
3131
This driver allows access to Mellanox programmable device register
3232
space through sysfs interface. The sets of registers for sysfs access
@@ -36,9 +36,9 @@ config MLXREG_IO
3636

3737
config MLXREG_LC
3838
tristate "Mellanox line card platform driver support"
39-
depends on REGMAP
4039
depends on HWMON
4140
depends on I2C
41+
select REGMAP
4242
help
4343
This driver provides support for the Mellanox MSN4800-XX line cards,
4444
which are the part of MSN4800 Ethernet modular switch systems
@@ -80,10 +80,9 @@ config MLXBF_PMC
8080

8181
config NVSW_SN2201
8282
tristate "Nvidia SN2201 platform driver support"
83-
depends on REGMAP
8483
depends on HWMON
8584
depends on I2C
86-
depends on REGMAP_I2C
85+
select REGMAP_I2C
8786
help
8887
This driver provides support for the Nvidia SN2201 platform.
8988
The SN2201 is a highly integrated for one rack unit system with

0 commit comments

Comments
 (0)