Skip to content

Commit 03f84b3

Browse files
PCI: dra7xx: Fix threaded IRQ request for "dra7xx-pcie-main" IRQ
Commit da87d35 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ") switched from devm_request_irq() to devm_request_threaded_irq() for the "dra7xx-pcie-main" interrupt. Since the primary handler was set to NULL, the "IRQF_ONESHOT" flag should have also been set. Fix this. Fixes: da87d35 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ") Suggested-by: Vignesh Raghavendra <[email protected]> Link: https://lore.kernel.org/linux-pci/[email protected] Reported-by: Udit Kumar <[email protected]> Signed-off-by: Siddharth Vadapalli <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]> Reviewed-by: Kevin Hilman <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Cc: [email protected]
1 parent 8400291 commit 03f84b3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/pci/controller/dwc/pci-dra7xx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,8 @@ static int dra7xx_pcie_probe(struct platform_device *pdev)
850850
dra7xx->mode = mode;
851851

852852
ret = devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler,
853-
IRQF_SHARED, "dra7xx-pcie-main", dra7xx);
853+
IRQF_SHARED | IRQF_ONESHOT,
854+
"dra7xx-pcie-main", dra7xx);
854855
if (ret) {
855856
dev_err(dev, "failed to request irq\n");
856857
goto err_gpio;

0 commit comments

Comments
 (0)