Skip to content

Commit 0416e7a

Browse files
amer-hamzakuba-moo
authored andcommitted
net: dsa: mv88e6xxx: error handling for serdes_power functions
Added default case to handle undefined cmode scenario in mv88e6393x_serdes_power() and mv88e6393x_serdes_power() methods. Addresses-Coverity: 1494644 ("Uninitialized scalar variable") Fixes: 21635d9 (net: dsa: mv88e6xxx: Fix application of erratum 4.8 for 88E6393X) Reviewed-by: Marek Behún <[email protected]> Signed-off-by: Ameer Hamza <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 8d6b32a commit 0416e7a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

drivers/net/dsa/mv88e6xxx/serdes.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -830,7 +830,7 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
830830
bool up)
831831
{
832832
u8 cmode = chip->ports[port].cmode;
833-
int err = 0;
833+
int err;
834834

835835
switch (cmode) {
836836
case MV88E6XXX_PORT_STS_CMODE_SGMII:
@@ -842,6 +842,9 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
842842
case MV88E6XXX_PORT_STS_CMODE_RXAUI:
843843
err = mv88e6390_serdes_power_10g(chip, lane, up);
844844
break;
845+
default:
846+
err = -EINVAL;
847+
break;
845848
}
846849

847850
if (!err && up)
@@ -1541,6 +1544,9 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
15411544
case MV88E6393X_PORT_STS_CMODE_10GBASER:
15421545
err = mv88e6390_serdes_power_10g(chip, lane, on);
15431546
break;
1547+
default:
1548+
err = -EINVAL;
1549+
break;
15441550
}
15451551

15461552
if (err)

0 commit comments

Comments
 (0)