Skip to content

Commit 0493e73

Browse files
jgunthorpewilldeacon
authored andcommitted
iommu/arm-smmu-v3: Add cpu_to_le64() around STRTAB_STE_0_V
STRTAB_STE_0_V is a CPU value, it needs conversion for sparse to be clean. The missing annotation was a mistake introduced by splitting the ops out from the STE writer. Fixes: 7da51af ("iommu/arm-smmu-v3: Make STE programming independent of the callers") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202403011441.5WqGrYjp-lkp@intel.com/ Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/0-v1-98b23ebb0c84+9f-smmu_cputole_jgg@nvidia.com Signed-off-by: Will Deacon <will@kernel.org>
1 parent 4cece76 commit 0493e73

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1139,7 +1139,8 @@ static void arm_smmu_write_ste(struct arm_smmu_master *master, u32 sid,
11391139
* requires a breaking update, zero the V bit, write all qwords
11401140
* but 0, then set qword 0
11411141
*/
1142-
unused_update.data[0] = entry->data[0] & (~STRTAB_STE_0_V);
1142+
unused_update.data[0] = entry->data[0] &
1143+
cpu_to_le64(~STRTAB_STE_0_V);
11431144
entry_set(smmu, sid, entry, &unused_update, 0, 1);
11441145
entry_set(smmu, sid, entry, target, 1, num_entry_qwords - 1);
11451146
entry_set(smmu, sid, entry, target, 0, 1);

0 commit comments

Comments
 (0)