Skip to content

Commit 051c355

Browse files
committed
Merge tag 'for_v5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
Pull ext2 and reiserfs cleanups from Jan Kara: "Two small cleanups for ext2 and one for reiserfs" * tag 'for_v5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs: reiserfs: Replace kmalloc with kcalloc in the comment ext2: code cleanup by removing ifdef macro surrounding ext2: Fix i_op setting for special inode
2 parents 07c8f3b + 5626de1 commit 051c355

File tree

5 files changed

+2
-13
lines changed

5 files changed

+2
-13
lines changed

fs/ext2/file.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,7 @@ const struct file_operations ext2_file_operations = {
196196
};
197197

198198
const struct inode_operations ext2_file_inode_operations = {
199-
#ifdef CONFIG_EXT2_FS_XATTR
200199
.listxattr = ext2_listxattr,
201-
#endif
202200
.getattr = ext2_getattr,
203201
.setattr = ext2_setattr,
204202
.get_acl = ext2_get_acl,

fs/ext2/namei.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,7 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode,
136136
err = PTR_ERR(inode);
137137
if (!IS_ERR(inode)) {
138138
init_special_inode(inode, inode->i_mode, rdev);
139-
#ifdef CONFIG_EXT2_FS_XATTR
140139
inode->i_op = &ext2_special_inode_operations;
141-
#endif
142140
mark_inode_dirty(inode);
143141
err = ext2_add_nondir(dentry, inode);
144142
}
@@ -413,9 +411,7 @@ const struct inode_operations ext2_dir_inode_operations = {
413411
.rmdir = ext2_rmdir,
414412
.mknod = ext2_mknod,
415413
.rename = ext2_rename,
416-
#ifdef CONFIG_EXT2_FS_XATTR
417414
.listxattr = ext2_listxattr,
418-
#endif
419415
.getattr = ext2_getattr,
420416
.setattr = ext2_setattr,
421417
.get_acl = ext2_get_acl,
@@ -424,9 +420,7 @@ const struct inode_operations ext2_dir_inode_operations = {
424420
};
425421

426422
const struct inode_operations ext2_special_inode_operations = {
427-
#ifdef CONFIG_EXT2_FS_XATTR
428423
.listxattr = ext2_listxattr,
429-
#endif
430424
.getattr = ext2_getattr,
431425
.setattr = ext2_setattr,
432426
.get_acl = ext2_get_acl,

fs/ext2/symlink.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,12 @@ const struct inode_operations ext2_symlink_inode_operations = {
2525
.get_link = page_get_link,
2626
.getattr = ext2_getattr,
2727
.setattr = ext2_setattr,
28-
#ifdef CONFIG_EXT2_FS_XATTR
2928
.listxattr = ext2_listxattr,
30-
#endif
3129
};
3230

3331
const struct inode_operations ext2_fast_symlink_inode_operations = {
3432
.get_link = simple_get_link,
3533
.getattr = ext2_getattr,
3634
.setattr = ext2_setattr,
37-
#ifdef CONFIG_EXT2_FS_XATTR
3835
.listxattr = ext2_listxattr,
39-
#endif
4036
};

fs/ext2/xattr.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ static inline void ext2_xattr_destroy_cache(struct mb_cache *cache)
100100
}
101101

102102
#define ext2_xattr_handlers NULL
103+
#define ext2_listxattr NULL
103104

104105
# endif /* CONFIG_EXT2_FS_XATTR */
105106

fs/reiserfs/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,7 @@ int reiserfs_get_block(struct inode *inode, sector_t block,
10661066
} else {
10671067
/* paste hole to the indirect item */
10681068
/*
1069-
* If kmalloc failed, max_to_insert becomes
1069+
* If kcalloc failed, max_to_insert becomes
10701070
* zero and it means we only have space for
10711071
* one block
10721072
*/

0 commit comments

Comments
 (0)