scsi: qla2xxx: Return -ENOMEM if kzalloc() fails

ZheyuMa · martinkpetersen · commit 06634d5b6e92 · 2021-10-18T23:01:10.000-04:00
The driver probing function should return < 0 for failure, otherwise kernel will treat value > 0 as success. Link: https://lore.kernel.org/r/1634522181-31166-1-git-send-email-zheyuma97@gmail.com Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
@@ -4157,7 +4157,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
 					ql_dbg_pci(ql_dbg_init, ha->pdev,
 					    0xe0ee, "%s: failed alloc dsd\n",
 					    __func__);
-					return 1;
+					return -ENOMEM;
 				}
 				ha->dif_bundle_kallocs++;
 

Original file line number	Diff line number	Diff line change
`@@ -4157,7 +4157,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,`
`4157`	`4157`	`ql_dbg_pci(ql_dbg_init, ha->pdev,`
`4158`	`4158`	`0xe0ee, "%s: failed alloc dsd\n",`
`4159`	`4159`	`__func__);`
`4160`		`- return 1;`
	`4160`	`+ return -ENOMEM;`
`4161`	`4161`	`}`
`4162`	`4162`	`ha->dif_bundle_kallocs++;`
`4163`	`4163`