Skip to content

Commit 066d7f3

Browse files
Wei Yongjunandy-shev
authored andcommitted
platform/x86: thinkpad_acpi: Make some symbols static
The sparse tool complains as follows: drivers/platform/x86/thinkpad_acpi.c:9636:25: warning: symbol 'dev_attr_charge_start_threshold' was not declared. Should it be static? drivers/platform/x86/thinkpad_acpi.c:9642:25: warning: symbol 'dev_attr_charge_stop_threshold' was not declared. Should it be static? Those variables are not used outside of thinkpad_acpi.c, so this commit marks them static. Fixes: e339295 ("platform/x86: thinkpad_acpi: use standard charge control attribute names") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Wei Yongjun <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent 6178129 commit 066d7f3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/platform/x86/thinkpad_acpi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9633,13 +9633,13 @@ static ssize_t charge_control_end_threshold_store(struct device *dev,
96339633

96349634
static DEVICE_ATTR_RW(charge_control_start_threshold);
96359635
static DEVICE_ATTR_RW(charge_control_end_threshold);
9636-
struct device_attribute dev_attr_charge_start_threshold = __ATTR(
9636+
static struct device_attribute dev_attr_charge_start_threshold = __ATTR(
96379637
charge_start_threshold,
96389638
0644,
96399639
charge_control_start_threshold_show,
96409640
charge_control_start_threshold_store
96419641
);
9642-
struct device_attribute dev_attr_charge_stop_threshold = __ATTR(
9642+
static struct device_attribute dev_attr_charge_stop_threshold = __ATTR(
96439643
charge_stop_threshold,
96449644
0644,
96459645
charge_control_end_threshold_show,

0 commit comments

Comments
 (0)