Skip to content

Commit 0689ea4

Browse files
Ben Skeggsmlankhorst
authored andcommitted
drm/nouveau/fifo/ga102: initialise chid on return from channel creation
Turns out caller isn't zero-initialised after-all. Fixes: 49b2dfc ("drm/nouveau/ga102-: support ttm buffer moves via copy engine") Reported-by: Karol Herbst <[email protected]> Signed-off-by: Ben Skeggs <[email protected]> Reviewed-by: Karol Herbst <[email protected]> Signed-off-by: Karol Herbst <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Maarten Lankhorst <[email protected]>
1 parent 64ec491 commit 0689ea4

File tree

1 file changed

+3
-0
lines changed
  • drivers/gpu/drm/nouveau/nvkm/engine/fifo

1 file changed

+3
-0
lines changed

drivers/gpu/drm/nouveau/nvkm/engine/fifo/ga102.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,9 @@ ga102_chan_new(struct nvkm_device *device,
179179
return -ENODEV;
180180

181181
chan->ctrl.chan = nvkm_rd32(device, chan->ctrl.runl + 0x004) & 0xfffffff0;
182+
183+
args->chid = 0;
184+
args->inst = 0;
182185
args->token = nvkm_rd32(device, chan->ctrl.runl + 0x008) & 0xffff0000;
183186

184187
ret = nvkm_memory_new(device, NVKM_MEM_TARGET_INST, 0x1000, 0x1000, true, &chan->mthd);

0 commit comments

Comments
 (0)