Skip to content

Commit 0702227

Browse files
committed
platform/x86: intel-vbtn: Drop HP Stream x360 Convertible PC 11 from allow-list
THe HP Stream x360 Convertible PC 11 DSDT has the following VGBS function: Method (VGBS, 0, Serialized) { If ((^^PCI0.LPCB.EC0.ROLS == Zero)) { VBDS = Zero } Else { VBDS = Zero } Return (VBDS) /* \_SB_.VGBI.VBDS */ } Which is obviously wrong, because it always returns 0 independent of the 2-in-1 being in laptop or tablet mode. This causes the intel-vbtn driver to initially report SW_TABLET_MODE = 1 to userspace, which is known to cause problems when the 2-in-1 is actually in laptop mode. During earlier testing this turned out to not be a problem because the 2-in-1 would do a Notify(..., 0xCC) or Notify(..., 0xCD) soon after the intel-vbtn driver loaded, correcting the SW_TABLET_MODE state. Further testing however has shown that this Notify() soon after the intel-vbtn driver loads, does not always happen. When the Notify does not happen, then intel-vbtn reports SW_TABLET_MODE = 1 resulting in a non-working touchpad. IOW the tablet-mode reporting is not reliable on this device, so it should be dropped from the allow-list, fixing the touchpad sometimes not working. Fixes: 8169bd3 ("platform/x86: intel-vbtn: Switch to an allow-list for SW_TABLET_MODE reporting") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]>
1 parent f419e59 commit 0702227

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/platform/x86/intel-vbtn.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,6 @@ static const struct dmi_system_id dmi_switches_allow_list[] = {
204204
DMI_MATCH(DMI_PRODUCT_NAME, "Venue 11 Pro 7130"),
205205
},
206206
},
207-
{
208-
.matches = {
209-
DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
210-
DMI_MATCH(DMI_PRODUCT_NAME, "HP Stream x360 Convertible PC 11"),
211-
},
212-
},
213207
{
214208
.matches = {
215209
DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),

0 commit comments

Comments
 (0)