Skip to content

Commit 071d068

Browse files
YuuoniyMarc Zyngier
authored andcommitted
irqchip/alpine-msi: Fix refcount leak in alpine_msix_init_domains
of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak. Fixes: e6b78f2 ("irqchip: Add the Alpine MSIX interrupt controller") Signed-off-by: Miaoqian Lin <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 6caa5a2 commit 071d068

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/irqchip/irq-alpine-msi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv,
199199
}
200200

201201
gic_domain = irq_find_host(gic_node);
202+
of_node_put(gic_node);
202203
if (!gic_domain) {
203204
pr_err("Failed to find the GIC domain\n");
204205
return -ENXIO;

0 commit comments

Comments
 (0)