Skip to content

Commit 0756bec

Browse files
Jeff Johnsonawilliam
authored andcommitted
vfio-mdev: add missing MODULE_DESCRIPTION() macros
Since commit 1fffe7a ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() will result in a warning with make W=1. The following warnings are being observed in samples/vfio-mdev: WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-mdev/mtty.o WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-mdev/mdpy.o WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-mdev/mdpy-fb.o WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-mdev/mbochs.o Add the missing invocations of the MODULE_DESCRIPTION() macro to these modules. And in the case of mtty.c, remove the now redundant instance of the MODULE_INFO() macro. Signed-off-by: Jeff Johnson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alex Williamson <[email protected]>
1 parent abe8103 commit 0756bec

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

samples/vfio-mdev/mbochs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@
8888
#define STORE_LE32(addr, val) (*(u32 *)addr = val)
8989

9090

91+
MODULE_DESCRIPTION("Mediated virtual PCI display host device driver");
9192
MODULE_LICENSE("GPL v2");
9293

9394
static int max_mbytes = 256;

samples/vfio-mdev/mdpy-fb.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,4 +229,5 @@ static int __init mdpy_fb_init(void)
229229
module_init(mdpy_fb_init);
230230

231231
MODULE_DEVICE_TABLE(pci, mdpy_fb_pci_table);
232+
MODULE_DESCRIPTION("Framebuffer driver for mdpy (mediated virtual pci display device)");
232233
MODULE_LICENSE("GPL v2");

samples/vfio-mdev/mdpy.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
#define STORE_LE32(addr, val) (*(u32 *)addr = val)
4141

4242

43+
MODULE_DESCRIPTION("Mediated virtual PCI display host device driver");
4344
MODULE_LICENSE("GPL v2");
4445

4546
#define MDPY_TYPE_1 "vga"

samples/vfio-mdev/mtty.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2058,6 +2058,6 @@ module_init(mtty_dev_init)
20582058
module_exit(mtty_dev_exit)
20592059

20602060
MODULE_LICENSE("GPL v2");
2061-
MODULE_INFO(supported, "Test driver that simulate serial port over PCI");
2061+
MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
20622062
MODULE_VERSION(VERSION_STRING);
20632063
MODULE_AUTHOR(DRIVER_AUTHOR);

0 commit comments

Comments
 (0)