Skip to content

Commit 07953c5

Browse files
committed
firmware_loader: enable XZ by default if compressed support is enabled
Commit 23cfbc6 ("firmware: Add the support for ZSTD-compressed firmware files") added support for ZSTD compression, but in the process also made the previously default XZ compression a config option. That means that anybody who upgrades their kernel and does a make oldconfig to update their configuration, will end up without the XZ compression that the configuration used to have. Add the 'default y' to make sure this doesn't happen. The whole compression question should probably be improved upon, since it is now possible to "enable" compression in the kernel config but not enable any actual compression algorithm, which makes it all very useless. It makes no sense to ask Kconfig questions that enable situations that are nonsensical like that. This at least fixes the immediate problem of a kernel update resulting in a nonbootable machine because of a missed option. Fixes: 23cfbc6 ("firmware: Add the support for ZSTD-compressed firmware files") Cc: Takashi Iwai <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 744983d commit 07953c5

File tree

1 file changed

+1
-0
lines changed
  • drivers/base/firmware_loader

1 file changed

+1
-0
lines changed

drivers/base/firmware_loader/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ config FW_LOADER_COMPRESS_XZ
177177
bool "Enable XZ-compressed firmware support"
178178
select FW_LOADER_PAGED_BUF
179179
select XZ_DEC
180+
default y
180181
help
181182
This option adds the support for XZ-compressed files.
182183
The files have to be compressed with either none or crc32

0 commit comments

Comments
 (0)