Skip to content

Commit 080abad

Browse files
neilbrownamschuma-ntap
authored andcommitted
NFS: restore module put when manager exits.
Commit f49169c ("NFSD: Remove svc_serv_ops::svo_module") removed calls to module_put_and_kthread_exit() from threads that acted as SUNRPC servers and had a related svc_serv_ops structure. This was correct. It ALSO removed the module_put_and_kthread_exit() call from nfs4_run_state_manager() which is NOT a SUNRPC service. Consequently every time the NFSv4 state manager runs the module count increments and won't be decremented. So the nfsv4 module cannot be unloaded. So restore the module_put_and_kthread_exit() call. Fixes: f49169c ("NFSD: Remove svc_serv_ops::svo_module") Signed-off-by: NeilBrown <[email protected]> Signed-off-by: Anna Schumaker <[email protected]>
1 parent 03c765b commit 080abad

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/nfs/nfs4state.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2753,5 +2753,6 @@ static int nfs4_run_state_manager(void *ptr)
27532753
goto again;
27542754

27552755
nfs_put_client(clp);
2756+
module_put_and_kthread_exit(0);
27562757
return 0;
27572758
}

0 commit comments

Comments
 (0)