Skip to content

Commit 0893392

Browse files
nxpfrankliShawn Guo
authored andcommitted
arm64: dts: imx8-ss-dma: fix can lpcg indices
can0_lpcg: clock-controller@5acd0000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>; } Col1: index, which existing dts try to get. Col2: actual index in lpcg driver. flexcan1: can@5a8d0000 { clocks = <&can0_lpcg 1>, <&can0_lpcg 0>; ^^ ^^ Should be: clocks = <&can0_lpcg IMX_LPCG_CLK_4>, <&can0_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. flexcan driver get IMX_SC_PM_CLK_PER by <&can0_lpcg 1> and <&can0_lpcg 0>. Although function can work, code logic is wrong. Fix it by using correct clock indices. Cc: [email protected] Fixes: 5e7d5b0 ("arm64: dts: imx8qxp: add flexcan in adma") Signed-off-by: Frank Li <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 8197508 commit 0893392

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,8 @@ dma_subsys: bus@5a000000 {
384384
reg = <0x5a8d0000 0x10000>;
385385
interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_HIGH>;
386386
interrupt-parent = <&gic>;
387-
clocks = <&can0_lpcg 1>,
388-
<&can0_lpcg 0>;
387+
clocks = <&can0_lpcg IMX_LPCG_CLK_4>,
388+
<&can0_lpcg IMX_LPCG_CLK_0>;
389389
clock-names = "ipg", "per";
390390
assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>;
391391
assigned-clock-rates = <40000000>;
@@ -405,8 +405,8 @@ dma_subsys: bus@5a000000 {
405405
* CAN1 shares CAN0's clock and to enable CAN0's clock it
406406
* has to be powered on.
407407
*/
408-
clocks = <&can0_lpcg 1>,
409-
<&can0_lpcg 0>;
408+
clocks = <&can0_lpcg IMX_LPCG_CLK_4>,
409+
<&can0_lpcg IMX_LPCG_CLK_0>;
410410
clock-names = "ipg", "per";
411411
assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>;
412412
assigned-clock-rates = <40000000>;
@@ -426,8 +426,8 @@ dma_subsys: bus@5a000000 {
426426
* CAN2 shares CAN0's clock and to enable CAN0's clock it
427427
* has to be powered on.
428428
*/
429-
clocks = <&can0_lpcg 1>,
430-
<&can0_lpcg 0>;
429+
clocks = <&can0_lpcg IMX_LPCG_CLK_4>,
430+
<&can0_lpcg IMX_LPCG_CLK_0>;
431431
clock-names = "ipg", "per";
432432
assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>;
433433
assigned-clock-rates = <40000000>;

0 commit comments

Comments
 (0)