Skip to content

Commit 08abd04

Browse files
tanmaybhushantytso
authored andcommitted
ext4: remove dead code in updating backup sb
ext4_update_backup_sb checks for err having some value after unlocking buffer. But err has not been updated till that point in any code which will lead execution of the code in question. Signed-off-by: Tanmay Bhushan <[email protected]> Reviewed-by: Jan Kara <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Theodore Ts'o <[email protected]>
1 parent 240930f commit 08abd04

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

fs/ext4/ioctl.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,
155155
set_buffer_uptodate(bh);
156156
unlock_buffer(bh);
157157

158-
if (err)
159-
goto out_bh;
160-
161158
if (handle) {
162159
err = ext4_handle_dirty_metadata(handle, NULL, bh);
163160
if (err)

0 commit comments

Comments
 (0)