Skip to content

Commit 08d564a

Browse files
ubizjakIngo Molnar
authored andcommitted
x86/percpu: Move some percpu macros around for readability
Move some percpu macros around to make a follow-up patch more readable. No functional change intended. Signed-off-by: Uros Bizjak <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: Josh Poimboeuf <[email protected]> Cc: Linus Torvalds <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 455ca13 commit 08d564a

File tree

1 file changed

+34
-29
lines changed

1 file changed

+34
-29
lines changed

arch/x86/include/asm/percpu.h

Lines changed: 34 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,29 @@
144144
#define __pcpu_reg_imm_4(x) "ri" (x)
145145
#define __pcpu_reg_imm_8(x) "re" (x)
146146

147+
#ifdef CONFIG_USE_X86_SEG_SUPPORT
148+
149+
#define __raw_cpu_read(qual, pcp) \
150+
({ \
151+
*(qual __my_cpu_type(pcp) *)__my_cpu_ptr(&(pcp)); \
152+
})
153+
154+
#define __raw_cpu_write(qual, pcp, val) \
155+
do { \
156+
*(qual __my_cpu_type(pcp) *)__my_cpu_ptr(&(pcp)) = (val); \
157+
} while (0)
158+
159+
#else /* CONFIG_USE_X86_SEG_SUPPORT */
160+
161+
#define percpu_from_op(size, qual, op, _var) \
162+
({ \
163+
__pcpu_type_##size pfo_val__; \
164+
asm qual (__pcpu_op2_##size(op, __percpu_arg([var]), "%[val]") \
165+
: [val] __pcpu_reg_##size("=", pfo_val__) \
166+
: [var] "m" (__my_cpu_var(_var))); \
167+
(typeof(_var))(unsigned long) pfo_val__; \
168+
})
169+
147170
#define percpu_to_op(size, qual, op, _var, _val) \
148171
do { \
149172
__pcpu_type_##size pto_val__ = __pcpu_cast_##size(_val); \
@@ -157,6 +180,17 @@ do { \
157180
: [val] __pcpu_reg_imm_##size(pto_val__)); \
158181
} while (0)
159182

183+
#endif /* CONFIG_USE_X86_SEG_SUPPORT */
184+
185+
#define percpu_stable_op(size, op, _var) \
186+
({ \
187+
__pcpu_type_##size pfo_val__; \
188+
asm(__pcpu_op2_##size(op, __force_percpu_arg(a[var]), "%[val]") \
189+
: [val] __pcpu_reg_##size("=", pfo_val__) \
190+
: [var] "i" (&(_var))); \
191+
(typeof(_var))(unsigned long) pfo_val__; \
192+
})
193+
160194
#define percpu_unary_op(size, qual, op, _var) \
161195
({ \
162196
asm qual (__pcpu_op1_##size(op, __percpu_arg([var])) \
@@ -198,24 +232,6 @@ do { \
198232
percpu_binary_op(size, qual, "add", var, val); \
199233
} while (0)
200234

201-
#define percpu_from_op(size, qual, op, _var) \
202-
({ \
203-
__pcpu_type_##size pfo_val__; \
204-
asm qual (__pcpu_op2_##size(op, __percpu_arg([var]), "%[val]") \
205-
: [val] __pcpu_reg_##size("=", pfo_val__) \
206-
: [var] "m" (__my_cpu_var(_var))); \
207-
(typeof(_var))(unsigned long) pfo_val__; \
208-
})
209-
210-
#define percpu_stable_op(size, op, _var) \
211-
({ \
212-
__pcpu_type_##size pfo_val__; \
213-
asm(__pcpu_op2_##size(op, __force_percpu_arg(a[var]), "%[val]") \
214-
: [val] __pcpu_reg_##size("=", pfo_val__) \
215-
: [var] "i" (&(_var))); \
216-
(typeof(_var))(unsigned long) pfo_val__; \
217-
})
218-
219235
/*
220236
* Add return operation
221237
*/
@@ -433,17 +449,6 @@ do { \
433449
#define this_cpu_read_stable(pcp) __pcpu_size_call_return(this_cpu_read_stable_, pcp)
434450

435451
#ifdef CONFIG_USE_X86_SEG_SUPPORT
436-
437-
#define __raw_cpu_read(qual, pcp) \
438-
({ \
439-
*(qual __my_cpu_type(pcp) *)__my_cpu_ptr(&(pcp)); \
440-
})
441-
442-
#define __raw_cpu_write(qual, pcp, val) \
443-
do { \
444-
*(qual __my_cpu_type(pcp) *)__my_cpu_ptr(&(pcp)) = (val); \
445-
} while (0)
446-
447452
#define raw_cpu_read_1(pcp) __raw_cpu_read(, pcp)
448453
#define raw_cpu_read_2(pcp) __raw_cpu_read(, pcp)
449454
#define raw_cpu_read_4(pcp) __raw_cpu_read(, pcp)

0 commit comments

Comments
 (0)