Skip to content

Commit 092a9f5

Browse files
ffainelligregkh
authored andcommitted
Revert "tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart"
This reverts commit 580d952 ("tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart") because we should not be doing a clk_put() if we were not successful in getting a valid clock reference via clk_get() in the first place. Fixes: 580d952 ("tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart") Signed-off-by: Florian Fainelli <[email protected]> Cc: stable <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6a8b55e commit 092a9f5

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/tty/serial/bcm63xx_uart.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -843,10 +843,8 @@ static int bcm_uart_probe(struct platform_device *pdev)
843843
if (IS_ERR(clk) && pdev->dev.of_node)
844844
clk = of_clk_get(pdev->dev.of_node, 0);
845845

846-
if (IS_ERR(clk)) {
847-
clk_put(clk);
846+
if (IS_ERR(clk))
848847
return -ENODEV;
849-
}
850848

851849
port->iotype = UPIO_MEM;
852850
port->irq = res_irq->start;

0 commit comments

Comments
 (0)