Skip to content

Commit 092f45b

Browse files
sean-anderson-secogregkh
authored andcommitted
usb: ulpi: Move of_node_put to ulpi_dev_release
Drivers are not unbound from the device when ulpi_unregister_interface is called. Move of_node-freeing code to ulpi_dev_release which is called only after all users are gone. Fixes: ef6a7bc ("usb: ulpi: Support device discovery via DT") Cc: stable <[email protected]> Reviewed-by: Heikki Krogerus <[email protected]> Signed-off-by: Sean Anderson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent ebe2b1a commit 092f45b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/common/ulpi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ static const struct attribute_group *ulpi_dev_attr_groups[] = {
130130

131131
static void ulpi_dev_release(struct device *dev)
132132
{
133+
of_node_put(dev->of_node);
133134
kfree(to_ulpi_dev(dev));
134135
}
135136

@@ -299,7 +300,6 @@ EXPORT_SYMBOL_GPL(ulpi_register_interface);
299300
*/
300301
void ulpi_unregister_interface(struct ulpi *ulpi)
301302
{
302-
of_node_put(ulpi->dev.of_node);
303303
device_unregister(&ulpi->dev);
304304
}
305305
EXPORT_SYMBOL_GPL(ulpi_unregister_interface);

0 commit comments

Comments
 (0)