Skip to content

Commit 097f1ee

Browse files
Tom Zanussirostedt
authored andcommitted
tracing: Propagate is_signed to expression
During expression parsing, a new expression field is created which should inherit the properties of the operands, such as size and is_signed. is_signed propagation was missing, causing spurious errors with signed operands. Add it in parse_expr() and parse_unary() to fix the problem. Link: https://lkml.kernel.org/r/f4dac08742fd7a0920bf80a73c6c44042f5eaa40.1643319703.git.zanussi@kernel.org Cc: [email protected] Fixes: 100719d ("tracing: Add simple expression support to hist triggers") Reported-by: Yordan Karadzhov <[email protected]> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215513 Signed-off-by: Tom Zanussi <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent b59f2f2 commit 097f1ee

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

kernel/trace/trace_events_hist.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2503,6 +2503,8 @@ static struct hist_field *parse_unary(struct hist_trigger_data *hist_data,
25032503
(HIST_FIELD_FL_TIMESTAMP | HIST_FIELD_FL_TIMESTAMP_USECS);
25042504
expr->fn = hist_field_unary_minus;
25052505
expr->operands[0] = operand1;
2506+
expr->size = operand1->size;
2507+
expr->is_signed = operand1->is_signed;
25062508
expr->operator = FIELD_OP_UNARY_MINUS;
25072509
expr->name = expr_str(expr, 0);
25082510
expr->type = kstrdup_const(operand1->type, GFP_KERNEL);
@@ -2719,6 +2721,7 @@ static struct hist_field *parse_expr(struct hist_trigger_data *hist_data,
27192721

27202722
/* The operand sizes should be the same, so just pick one */
27212723
expr->size = operand1->size;
2724+
expr->is_signed = operand1->is_signed;
27222725

27232726
expr->operator = field_op;
27242727
expr->type = kstrdup_const(operand1->type, GFP_KERNEL);

0 commit comments

Comments
 (0)