Skip to content

Commit 098c9db

Browse files
committed
spi: davinci: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2] this[3] macro[4], just remove this variable since it was actually unused: drivers/spi/spi-davinci.c: In function ‘davinci_spi_bufs’: drivers/spi/spi-davinci.c:579:11: warning: unused variable ‘rx_buf_count’ [-Wunused-variable] 579 | unsigned rx_buf_count; | ^~~~~~~~~~~~ [1] https://lore.kernel.org/lkml/[email protected]/ [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ Fixes: 048177c ("spi: spi-davinci: convert to DMA engine API") Reviewed-by: Nick Desaulniers <[email protected]> Acked-by: Mark Brown <[email protected]> Signed-off-by: Kees Cook <[email protected]>
1 parent eecd48c commit 098c9db

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/spi/spi-davinci.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,6 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t)
576576
u32 errors = 0;
577577
struct davinci_spi_config *spicfg;
578578
struct davinci_spi_platform_data *pdata;
579-
unsigned uninitialized_var(rx_buf_count);
580579

581580
dspi = spi_master_get_devdata(spi->master);
582581
pdata = &dspi->pdata;

0 commit comments

Comments
 (0)