Skip to content

Commit 09d6ac8

Browse files
djbwaxboe
authored andcommitted
libata/ahci: Fix PCS quirk application
Commit c312ef1 "libata/ahci: Drop PCS quirk for Denverton and beyond" got the polarity wrong on the check for which board-ids should have the quirk applied. The board type board_ahci_pcs7 is defined at the end of the list such that "pcs7" boards can be special cased in the future if they need the quirk. All prior Intel board ids "< board_ahci_pcs7" should proceed with applying the quirk. Reported-by: Andreas Friedrich <[email protected]> Reported-by: Stephen Douthit <[email protected]> Fixes: c312ef1 ("libata/ahci: Drop PCS quirk for Denverton and beyond") Cc: <[email protected]> Signed-off-by: Dan Williams <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 307f406 commit 09d6ac8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/ata/ahci.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1600,7 +1600,9 @@ static void ahci_intel_pcs_quirk(struct pci_dev *pdev, struct ahci_host_priv *hp
16001600
*/
16011601
if (!id || id->vendor != PCI_VENDOR_ID_INTEL)
16021602
return;
1603-
if (((enum board_ids) id->driver_data) < board_ahci_pcs7)
1603+
1604+
/* Skip applying the quirk on Denverton and beyond */
1605+
if (((enum board_ids) id->driver_data) >= board_ahci_pcs7)
16041606
return;
16051607

16061608
/*

0 commit comments

Comments
 (0)