Skip to content

Commit 0a94a46

Browse files
Christoph HellwigMikulas Patocka
authored andcommitted
dm: stop using blk_limits_io_{min,opt}
Remove use of the blk_limits_io_{min,opt} and assign the values directly to the queue_limits structure. For the io_opt this is a completely mechanical change, for io_min it removes flooring the limit to the physical and logical block size in the particular caller. But as blk_validate_limits will do the same later when actually applying the limits, there still is no change in overall behavior. Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Mikulas Patocka <[email protected]>
1 parent 0d815e3 commit 0a94a46

File tree

11 files changed

+20
-20
lines changed

11 files changed

+20
-20
lines changed

drivers/md/dm-cache-target.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3416,8 +3416,8 @@ static void cache_io_hints(struct dm_target *ti, struct queue_limits *limits)
34163416
*/
34173417
if (io_opt_sectors < cache->sectors_per_block ||
34183418
do_div(io_opt_sectors, cache->sectors_per_block)) {
3419-
blk_limits_io_min(limits, cache->sectors_per_block << SECTOR_SHIFT);
3420-
blk_limits_io_opt(limits, cache->sectors_per_block << SECTOR_SHIFT);
3419+
limits->io_min = cache->sectors_per_block << SECTOR_SHIFT;
3420+
limits->io_opt = cache->sectors_per_block << SECTOR_SHIFT;
34213421
}
34223422

34233423
disable_passdown_if_not_supported(cache);

drivers/md/dm-clone-target.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2073,8 +2073,8 @@ static void clone_io_hints(struct dm_target *ti, struct queue_limits *limits)
20732073
*/
20742074
if (io_opt_sectors < clone->region_size ||
20752075
do_div(io_opt_sectors, clone->region_size)) {
2076-
blk_limits_io_min(limits, clone->region_size << SECTOR_SHIFT);
2077-
blk_limits_io_opt(limits, clone->region_size << SECTOR_SHIFT);
2076+
limits->io_min = clone->region_size << SECTOR_SHIFT;
2077+
limits->io_opt = clone->region_size << SECTOR_SHIFT;
20782078
}
20792079

20802080
disable_passdown_if_not_supported(clone);

drivers/md/dm-ebs-target.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ static void ebs_io_hints(struct dm_target *ti, struct queue_limits *limits)
428428
limits->logical_block_size = to_bytes(ec->e_bs);
429429
limits->physical_block_size = to_bytes(ec->u_bs);
430430
limits->alignment_offset = limits->physical_block_size;
431-
blk_limits_io_min(limits, limits->logical_block_size);
431+
limits->io_min = limits->logical_block_size;
432432
}
433433

434434
static int ebs_iterate_devices(struct dm_target *ti,

drivers/md/dm-era-target.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1733,8 +1733,8 @@ static void era_io_hints(struct dm_target *ti, struct queue_limits *limits)
17331733
*/
17341734
if (io_opt_sectors < era->sectors_per_block ||
17351735
do_div(io_opt_sectors, era->sectors_per_block)) {
1736-
blk_limits_io_min(limits, 0);
1737-
blk_limits_io_opt(limits, era->sectors_per_block << SECTOR_SHIFT);
1736+
limits->io_min = 0;
1737+
limits->io_opt = era->sectors_per_block << SECTOR_SHIFT;
17381738
}
17391739
}
17401740

drivers/md/dm-integrity.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3471,7 +3471,7 @@ static void dm_integrity_io_hints(struct dm_target *ti, struct queue_limits *lim
34713471
if (ic->sectors_per_block > 1) {
34723472
limits->logical_block_size = ic->sectors_per_block << SECTOR_SHIFT;
34733473
limits->physical_block_size = ic->sectors_per_block << SECTOR_SHIFT;
3474-
blk_limits_io_min(limits, ic->sectors_per_block << SECTOR_SHIFT);
3474+
limits->io_min = ic->sectors_per_block << SECTOR_SHIFT;
34753475
limits->dma_alignment = limits->logical_block_size - 1;
34763476
limits->discard_granularity = ic->sectors_per_block << SECTOR_SHIFT;
34773477
}

drivers/md/dm-raid.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3802,8 +3802,8 @@ static void raid_io_hints(struct dm_target *ti, struct queue_limits *limits)
38023802
struct raid_set *rs = ti->private;
38033803
unsigned int chunk_size_bytes = to_bytes(rs->md.chunk_sectors);
38043804

3805-
blk_limits_io_min(limits, chunk_size_bytes);
3806-
blk_limits_io_opt(limits, chunk_size_bytes * mddev_data_stripes(rs));
3805+
limits->io_min = chunk_size_bytes;
3806+
limits->io_opt = chunk_size_bytes * mddev_data_stripes(rs);
38073807
}
38083808

38093809
static void raid_presuspend(struct dm_target *ti)

drivers/md/dm-stripe.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,8 @@ static void stripe_io_hints(struct dm_target *ti,
459459
struct stripe_c *sc = ti->private;
460460
unsigned int chunk_size = sc->chunk_size << SECTOR_SHIFT;
461461

462-
blk_limits_io_min(limits, chunk_size);
463-
blk_limits_io_opt(limits, chunk_size * sc->stripes);
462+
limits->io_min = chunk_size;
463+
limits->io_opt = chunk_size * sc->stripes;
464464
}
465465

466466
static struct target_type stripe_target = {

drivers/md/dm-thin.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4079,10 +4079,10 @@ static void pool_io_hints(struct dm_target *ti, struct queue_limits *limits)
40794079
if (io_opt_sectors < pool->sectors_per_block ||
40804080
!is_factor(io_opt_sectors, pool->sectors_per_block)) {
40814081
if (is_factor(pool->sectors_per_block, limits->max_sectors))
4082-
blk_limits_io_min(limits, limits->max_sectors << SECTOR_SHIFT);
4082+
limits->io_min = limits->max_sectors << SECTOR_SHIFT;
40834083
else
4084-
blk_limits_io_min(limits, pool->sectors_per_block << SECTOR_SHIFT);
4085-
blk_limits_io_opt(limits, pool->sectors_per_block << SECTOR_SHIFT);
4084+
limits->io_min = pool->sectors_per_block << SECTOR_SHIFT;
4085+
limits->io_opt = pool->sectors_per_block << SECTOR_SHIFT;
40864086
}
40874087

40884088
/*

drivers/md/dm-vdo/dm-vdo-target.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -928,9 +928,9 @@ static void vdo_io_hints(struct dm_target *ti, struct queue_limits *limits)
928928
limits->physical_block_size = VDO_BLOCK_SIZE;
929929

930930
/* The minimum io size for random io */
931-
blk_limits_io_min(limits, VDO_BLOCK_SIZE);
931+
limits->io_min = VDO_BLOCK_SIZE;
932932
/* The optimal io size for streamed/sequential io */
933-
blk_limits_io_opt(limits, VDO_BLOCK_SIZE);
933+
limits->io_opt = VDO_BLOCK_SIZE;
934934

935935
/*
936936
* Sets the maximum discard size that will be passed into VDO. This value comes from a

drivers/md/dm-verity-target.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -919,7 +919,7 @@ static void verity_io_hints(struct dm_target *ti, struct queue_limits *limits)
919919
if (limits->physical_block_size < 1 << v->data_dev_block_bits)
920920
limits->physical_block_size = 1 << v->data_dev_block_bits;
921921

922-
blk_limits_io_min(limits, limits->logical_block_size);
922+
limits->io_min = limits->logical_block_size;
923923

924924
/*
925925
* Similar to what dm-crypt does, opt dm-verity out of support for

0 commit comments

Comments
 (0)