Skip to content

Commit 0aa34b3

Browse files
Sebastian Ottoupton
authored andcommitted
KVM: arm64: fix kdoc warnings in W=1 builds
Fix kdoc warnings by adding missing function parameter descriptions or by conversion to a normal comment. Signed-off-by: Sebastian Ott <[email protected]> Reviewed-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Oliver Upton <[email protected]>
1 parent 963a08e commit 0aa34b3

File tree

4 files changed

+17
-11
lines changed

4 files changed

+17
-11
lines changed

arch/arm64/kvm/arm.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ static int kvm_arm_default_max_vcpus(void)
164164
/**
165165
* kvm_arch_init_vm - initializes a VM data structure
166166
* @kvm: pointer to the KVM struct
167+
* @type: kvm device type
167168
*/
168169
int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
169170
{

arch/arm64/kvm/vgic/vgic-irqfd.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include <kvm/arm_vgic.h>
1010
#include "vgic.h"
1111

12-
/**
12+
/*
1313
* vgic_irqfd_set_irq: inject the IRQ corresponding to the
1414
* irqchip routing entry
1515
*
@@ -75,7 +75,8 @@ static void kvm_populate_msi(struct kvm_kernel_irq_routing_entry *e,
7575
msi->flags = e->msi.flags;
7676
msi->devid = e->msi.devid;
7777
}
78-
/**
78+
79+
/*
7980
* kvm_set_msi: inject the MSI corresponding to the
8081
* MSI routing entry
8182
*
@@ -98,7 +99,7 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e,
9899
return vgic_its_inject_msi(kvm, &msi);
99100
}
100101

101-
/**
102+
/*
102103
* kvm_arch_set_irq_inatomic: fast-path for irqfd injection
103104
*/
104105
int kvm_arch_set_irq_inatomic(struct kvm_kernel_irq_routing_entry *e,

arch/arm64/kvm/vgic/vgic-its.c

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2040,6 +2040,7 @@ typedef int (*entry_fn_t)(struct vgic_its *its, u32 id, void *entry,
20402040
* @start_id: the ID of the first entry in the table
20412041
* (non zero for 2d level tables)
20422042
* @fn: function to apply on each entry
2043+
* @opaque: pointer to opaque data
20432044
*
20442045
* Return: < 0 on error, 0 if last element was identified, 1 otherwise
20452046
* (the last element may not be found on second level tables)
@@ -2079,7 +2080,7 @@ static int scan_its_table(struct vgic_its *its, gpa_t base, int size, u32 esz,
20792080
return 1;
20802081
}
20812082

2082-
/**
2083+
/*
20832084
* vgic_its_save_ite - Save an interrupt translation entry at @gpa
20842085
*/
20852086
static int vgic_its_save_ite(struct vgic_its *its, struct its_device *dev,
@@ -2099,6 +2100,8 @@ static int vgic_its_save_ite(struct vgic_its *its, struct its_device *dev,
20992100

21002101
/**
21012102
* vgic_its_restore_ite - restore an interrupt translation entry
2103+
*
2104+
* @its: its handle
21022105
* @event_id: id used for indexing
21032106
* @ptr: pointer to the ITE entry
21042107
* @opaque: pointer to the its_device
@@ -2231,6 +2234,7 @@ static int vgic_its_restore_itt(struct vgic_its *its, struct its_device *dev)
22312234
* @its: ITS handle
22322235
* @dev: ITS device
22332236
* @ptr: GPA
2237+
* @dte_esz: device table entry size
22342238
*/
22352239
static int vgic_its_save_dte(struct vgic_its *its, struct its_device *dev,
22362240
gpa_t ptr, int dte_esz)
@@ -2313,7 +2317,7 @@ static int vgic_its_device_cmp(void *priv, const struct list_head *a,
23132317
return 1;
23142318
}
23152319

2316-
/**
2320+
/*
23172321
* vgic_its_save_device_tables - Save the device table and all ITT
23182322
* into guest RAM
23192323
*
@@ -2386,7 +2390,7 @@ static int handle_l1_dte(struct vgic_its *its, u32 id, void *addr,
23862390
return ret;
23872391
}
23882392

2389-
/**
2393+
/*
23902394
* vgic_its_restore_device_tables - Restore the device table and all ITT
23912395
* from guest RAM to internal data structs
23922396
*/
@@ -2478,7 +2482,7 @@ static int vgic_its_restore_cte(struct vgic_its *its, gpa_t gpa, int esz)
24782482
return 1;
24792483
}
24802484

2481-
/**
2485+
/*
24822486
* vgic_its_save_collection_table - Save the collection table into
24832487
* guest RAM
24842488
*/
@@ -2518,7 +2522,7 @@ static int vgic_its_save_collection_table(struct vgic_its *its)
25182522
return ret;
25192523
}
25202524

2521-
/**
2525+
/*
25222526
* vgic_its_restore_collection_table - reads the collection table
25232527
* in guest memory and restores the ITS internal state. Requires the
25242528
* BASER registers to be restored before.
@@ -2556,7 +2560,7 @@ static int vgic_its_restore_collection_table(struct vgic_its *its)
25562560
return ret;
25572561
}
25582562

2559-
/**
2563+
/*
25602564
* vgic_its_save_tables_v0 - Save the ITS tables into guest ARM
25612565
* according to v0 ABI
25622566
*/
@@ -2571,7 +2575,7 @@ static int vgic_its_save_tables_v0(struct vgic_its *its)
25712575
return vgic_its_save_collection_table(its);
25722576
}
25732577

2574-
/**
2578+
/*
25752579
* vgic_its_restore_tables_v0 - Restore the ITS tables from guest RAM
25762580
* to internal data structs according to V0 ABI
25772581
*

arch/arm64/kvm/vgic/vgic-v3.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ static void map_all_vpes(struct kvm *kvm)
370370
dist->its_vm.vpes[i]->irq));
371371
}
372372

373-
/**
373+
/*
374374
* vgic_v3_save_pending_tables - Save the pending tables into guest RAM
375375
* kvm lock and all vcpu lock must be held
376376
*/

0 commit comments

Comments
 (0)