Skip to content

Commit 0aac6f9

Browse files
author
Jiri Kosina
committed
Merge branch 'for-5.6/upstream-fixes' into for-linus
- probe fix for Logitech-G* devices from Hans de Goede - error handling imrovement in hid-rmi from Christophe JAILLET
2 parents 819d578 + 2e1b9e1 commit 0aac6f9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

drivers/hid/hid-lg-g15.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -803,8 +803,10 @@ static int lg_g15_probe(struct hid_device *hdev, const struct hid_device_id *id)
803803
}
804804

805805
if (ret < 0) {
806-
hid_err(hdev, "Error disabling keyboard emulation for the G-keys\n");
807-
goto error_hw_stop;
806+
hid_err(hdev, "Error %d disabling keyboard emulation for the G-keys, falling back to generic hid-input driver\n",
807+
ret);
808+
hid_set_drvdata(hdev, NULL);
809+
return 0;
808810
}
809811

810812
/* Get initial brightness levels */

drivers/hid/hid-rmi.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ static int rmi_hid_read_block(struct rmi_transport_dev *xport, u16 addr,
217217
ret = rmi_write_report(hdev, data->writeReport,
218218
data->output_report_size);
219219
if (ret != data->output_report_size) {
220-
clear_bit(RMI_READ_REQUEST_PENDING, &data->flags);
221220
dev_err(&hdev->dev,
222221
"failed to write request output report (%d)\n",
223222
ret);

0 commit comments

Comments
 (0)