Skip to content

Commit 0ab4bcf

Browse files
fallenwsakernel
authored andcommitted
i2c: at91: Use dev_err_probe() instead of dev_err()
Change if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); } into return dev_err_probe() Also, return the correct error instead of hardcoding -ENODEV This change has also the advantage of handling the -EPROBE_DEFER situation. Signed-off-by: Yann Sionneau <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent e23e610 commit 0ab4bcf

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/i2c/busses/i2c-at91-core.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,10 +222,9 @@ static int at91_twi_probe(struct platform_device *pdev)
222222
platform_set_drvdata(pdev, dev);
223223

224224
dev->clk = devm_clk_get(dev->dev, NULL);
225-
if (IS_ERR(dev->clk)) {
226-
dev_err(dev->dev, "no clock defined\n");
227-
return -ENODEV;
228-
}
225+
if (IS_ERR(dev->clk))
226+
return dev_err_probe(dev->dev, PTR_ERR(dev->clk), "no clock defined\n");
227+
229228
clk_prepare_enable(dev->clk);
230229

231230
snprintf(dev->adapter.name, sizeof(dev->adapter.name), "AT91");

0 commit comments

Comments
 (0)