Skip to content

Commit 0b24be4

Browse files
Christoph Hellwigaxboe
authored andcommitted
splice: don't call file_accessed in copy_splice_read
copy_splice_read calls into ->read_iter to read the data, which already calls file_accessed. Fixes: 33b3b04 ("splice: Add a func to do a splice from an O_DIRECT file without ITER_PIPE") Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Reviewed-by: Christian Brauner <[email protected]> Reviewed-by: David Howells <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 236f255 commit 0b24be4

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/splice.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,6 @@ ssize_t copy_splice_read(struct file *in, loff_t *ppos,
368368
if (ret > 0) {
369369
keep = DIV_ROUND_UP(ret, PAGE_SIZE);
370370
*ppos = kiocb.ki_pos;
371-
file_accessed(in);
372371
} else if (ret < 0) {
373372
/*
374373
* callers of ->splice_read() expect -EAGAIN on

0 commit comments

Comments
 (0)