Skip to content

Commit 0b33a33

Browse files
nhukcAbhinav Kumar
authored andcommitted
drm/msm: Fix return type of mdp4_lvds_connector_mode_valid
The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode *mode); The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of mdp4_lvds_connector_mode_valid should be changed from int to enum drm_mode_status. Reported-by: Dan Carpenter <[email protected]> Link: ClangBuiltLinux#1703 Cc: [email protected] Signed-off-by: Nathan Huckleberry <[email protected]> Fixes: 3e87599 ("drm/msm/mdp4: add LVDS panel support") Reviewed-by: Abhinav Kumar <[email protected]> Reviewed-by: Nathan Chancellor <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/502878/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Abhinav Kumar <[email protected]>
1 parent 3a66124 commit 0b33a33

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@ static int mdp4_lvds_connector_get_modes(struct drm_connector *connector)
5656
return ret;
5757
}
5858

59-
static int mdp4_lvds_connector_mode_valid(struct drm_connector *connector,
60-
struct drm_display_mode *mode)
59+
static enum drm_mode_status
60+
mdp4_lvds_connector_mode_valid(struct drm_connector *connector,
61+
struct drm_display_mode *mode)
6162
{
6263
struct mdp4_lvds_connector *mdp4_lvds_connector =
6364
to_mdp4_lvds_connector(connector);

0 commit comments

Comments
 (0)