Skip to content

Commit 0be0ae1

Browse files
pmachatadavem330
authored andcommitted
mlxsw: spectrum_flower: Do not stop at FLOW_ACTION_PRIORITY
The handler for FLOW_ACTION_PRIORITY ends by returning whatever the lower-level function that it calls returns. If there are more actions lined up after this action, those are never offloaded. Fix by only bailing out when the called function returns an error. Fixes: 463957e ("mlxsw: spectrum_flower: Offload FLOW_ACTION_PRIORITY") Signed-off-by: Petr Machata <[email protected]> Reviewed-by: Jiri Pirko <[email protected]> Signed-off-by: Ido Schimmel <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 95099c5 commit 0be0ae1

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,12 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
155155
proto, prio, extack);
156156
}
157157
case FLOW_ACTION_PRIORITY:
158-
return mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei,
159-
act->priority,
160-
extack);
158+
err = mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei,
159+
act->priority,
160+
extack);
161+
if (err)
162+
return err;
163+
break;
161164
case FLOW_ACTION_MANGLE: {
162165
enum flow_action_mangle_base htype = act->mangle.htype;
163166
__be32 be_mask = (__force __be32) act->mangle.mask;

0 commit comments

Comments
 (0)