Skip to content

Commit 0c16c83

Browse files
arndbdjbw
authored andcommitted
dax: cxl: add CXL_REGION dependency
There is already a dependency on CXL_REGION, which depends on CXL_BUS, but since CXL_REGION is a 'bool' symbol, it's possible to configure DAX as built-in even though CXL itself is a loadable module: x86_64-linux-ld: drivers/dax/cxl.o: in function `cxl_dax_region_probe': cxl.c:(.text+0xb): undefined reference to `to_cxl_dax_region' x86_64-linux-ld: drivers/dax/cxl.o: in function `cxl_dax_region_driver_init': cxl.c:(.init.text+0x10): undefined reference to `__cxl_driver_register' x86_64-linux-ld: drivers/dax/cxl.o: in function `cxl_dax_region_driver_exit': cxl.c:(.exit.text+0x9): undefined reference to `cxl_driver_unregister' Prevent this with another depndency on the tristate symbol. Fixes: 09d09e0 ("cxl/dax: Create dax devices for CXL RAM regions") Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dan Williams <[email protected]>
1 parent 7abcb0b commit 0c16c83

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/dax/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ config DEV_DAX_HMEM
4747

4848
config DEV_DAX_CXL
4949
tristate "CXL DAX: direct access to CXL RAM regions"
50-
depends on CXL_REGION && DEV_DAX
50+
depends on CXL_BUS && CXL_REGION && DEV_DAX
5151
default CXL_REGION && DEV_DAX
5252
help
5353
CXL RAM regions are either mapped by platform-firmware

0 commit comments

Comments
 (0)