Skip to content

Commit 0c640d9

Browse files
claudiubezneanoglitch
authored andcommitted
ARM: dts: at91: fix pinctrl phandles
Commit bf78186 ("ARM: dts: at91: add pinctrl-{names, 0} for all gpios") introduces pinctrl phandles for pins used by individual controllers to avoid failures due to commit 2ab73c6 ("gpio: Support GPIO controllers without pin-ranges"). For SPI controllers available on SAMA5D4 and SAMA5D3 some of the pins are defined in SoC specific dtsi on behalf of pinctrl-0. Adding extra pinctrl phandles on board specific dts also on behalf of pinctrl-0 overwrite the pinctrl-0 phandle specified in SoC specific dtsi. Thus add the board specific pinctrl to pinctrl-1. Fixes: bf78186 ("ARM: dts: at91: add pinctrl-{names, 0} for all gpios") Depends-on: 5c8b498 ("ARM: dts: at91: sama5d4_xplained: fix pinctrl phandle name") Reported-by: Ajay Kathat <[email protected]> Co-developed-by: Ajay Kathat <[email protected]> Signed-off-by: Ajay Kathat <[email protected]> Tested-by: Ajay Kathat <[email protected]> Signed-off-by: Claudiu Beznea <[email protected]> Signed-off-by: Nicolas Ferre <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 5c8b498 commit 0c640d9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

arch/arm/boot/dts/at91-sama5d3_xplained.dts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@
5757
};
5858

5959
spi0: spi@f0004000 {
60-
pinctrl-names = "default";
61-
pinctrl-0 = <&pinctrl_spi0_cs>;
60+
pinctrl-names = "default", "cs";
61+
pinctrl-1 = <&pinctrl_spi0_cs>;
6262
cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>;
6363
status = "okay";
6464
};
@@ -171,8 +171,8 @@
171171
};
172172

173173
spi1: spi@f8008000 {
174-
pinctrl-names = "default";
175-
pinctrl-0 = <&pinctrl_spi1_cs>;
174+
pinctrl-names = "default", "cs";
175+
pinctrl-1 = <&pinctrl_spi1_cs>;
176176
cs-gpios = <&pioC 25 0>;
177177
status = "okay";
178178
};

arch/arm/boot/dts/at91-sama5d4_xplained.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@
8181
};
8282

8383
spi1: spi@fc018000 {
84-
pinctrl-names = "default";
85-
pinctrl-0 = <&pinctrl_spi1_cs>;
84+
pinctrl-names = "default", "cs";
85+
pinctrl-1 = <&pinctrl_spi1_cs>;
8686
cs-gpios = <&pioB 21 0>;
8787
status = "okay";
8888
};

0 commit comments

Comments
 (0)