Skip to content

Commit 0c65dc0

Browse files
bhadanednyaneshwarRadhakrishna Sripada
authored andcommitted
drm/i915/jsl: s/JSL/JASPERLAKE for platform/subplatform defines
Follow consistent naming convention. Replace JSL with JASPERLAKE. Unroll IS_JSL_EHL() define with IS_JASPERLAKE() || IS_ELKHARTLAKE() condition. Change in the display step define for Jasperlake. v2: - Change subject prefix skl instead of SKL(Anusha) v3: - Remove the use of define IS_JSL_EHL. - Replace with IS_JASPERLAKE() || IS_ELKHARTLAKE() - Unrolled wrapper IS_JSL_ELK_DISPLAY_STEP (Jani/Tvrtko) v4: - Removed unused macro v5: - Resolved valid checkpatch warning(Jani) Cc: Tvrtko Ursulin <[email protected]> Cc: Jani Nikula <[email protected]> Cc: Anusha Srivatsa <[email protected]> Signed-off-by: Dnyaneshwar Bhadane <[email protected]> Acked-by: Jani Nikula <[email protected]> Signed-off-by: Radhakrishna Sripada <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent e549097 commit 0c65dc0

15 files changed

+47
-38
lines changed

drivers/gpu/drm/i915/display/icl_dsi.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,8 @@ static void gen11_dsi_config_phy_lanes_sequence(struct intel_encoder *encoder)
444444
intel_de_write(dev_priv, ICL_PORT_TX_DW2_GRP(phy), tmp);
445445

446446
/* For EHL, TGL, set latency optimization for PCS_DW1 lanes */
447-
if (IS_JSL_EHL(dev_priv) || (DISPLAY_VER(dev_priv) >= 12)) {
447+
if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv) ||
448+
(DISPLAY_VER(dev_priv) >= 12)) {
448449
intel_de_rmw(dev_priv, ICL_PORT_PCS_DW1_AUX(phy),
449450
LATENCY_OPTIM_MASK, LATENCY_OPTIM_VAL(0));
450451

@@ -553,7 +554,7 @@ gen11_dsi_setup_dphy_timings(struct intel_encoder *encoder,
553554
}
554555
}
555556

556-
if (IS_JSL_EHL(dev_priv)) {
557+
if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) {
557558
for_each_dsi_phy(phy, intel_dsi->phys)
558559
intel_de_rmw(dev_priv, ICL_DPHY_CHKN(phy),
559560
0, ICL_DPHY_CHKN_AFE_OVER_PPI_STRAP);

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3155,7 +3155,7 @@ static int intel_compute_max_dotclk(struct drm_i915_private *dev_priv)
31553155
*/
31563156
void intel_update_max_cdclk(struct drm_i915_private *dev_priv)
31573157
{
3158-
if (IS_JSL_EHL(dev_priv)) {
3158+
if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) {
31593159
if (dev_priv->display.cdclk.hw.ref == 24000)
31603160
dev_priv->display.cdclk.max_cdclk_freq = 552000;
31613161
else
@@ -3583,7 +3583,7 @@ void intel_init_cdclk_hooks(struct drm_i915_private *dev_priv)
35833583
} else if (DISPLAY_VER(dev_priv) >= 12) {
35843584
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
35853585
dev_priv->display.cdclk.table = icl_cdclk_table;
3586-
} else if (IS_JSL_EHL(dev_priv)) {
3586+
} else if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) {
35873587
dev_priv->display.funcs.cdclk = &ehl_cdclk_funcs;
35883588
dev_priv->display.cdclk.table = icl_cdclk_table;
35893589
} else if (DISPLAY_VER(dev_priv) >= 11) {

drivers/gpu/drm/i915/display/intel_combo_phy.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ static bool has_phy_misc(struct drm_i915_private *i915, enum phy phy)
141141

142142
if (IS_ALDERLAKE_S(i915))
143143
return phy == PHY_A;
144-
else if (IS_JSL_EHL(i915) ||
144+
else if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) ||
145145
IS_ROCKETLAKE(i915) ||
146146
IS_DG1(i915))
147147
return phy < PHY_C;
@@ -242,7 +242,7 @@ static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv,
242242
ret &= check_phy_reg(dev_priv, phy, ICL_PORT_COMP_DW8(phy),
243243
IREFGEN, IREFGEN);
244244

245-
if (IS_JSL_EHL(dev_priv)) {
245+
if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) {
246246
if (ehl_vbt_ddi_d_present(dev_priv))
247247
expected_val = ICL_PHY_MISC_MUX_DDID;
248248

@@ -333,7 +333,8 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
333333
* "internal" child devices.
334334
*/
335335
val = intel_de_read(dev_priv, ICL_PHY_MISC(phy));
336-
if (IS_JSL_EHL(dev_priv) && phy == PHY_A) {
336+
if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
337+
phy == PHY_A) {
337338
val &= ~ICL_PHY_MISC_MUX_DDID;
338339

339340
if (ehl_vbt_ddi_d_present(dev_priv))

drivers/gpu/drm/i915/display/intel_ddi.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3583,7 +3583,8 @@ void intel_ddi_compute_min_voltage_level(struct drm_i915_private *dev_priv,
35833583
{
35843584
if (DISPLAY_VER(dev_priv) >= 12 && crtc_state->port_clock > 594000)
35853585
crtc_state->min_voltage_level = 2;
3586-
else if (IS_JSL_EHL(dev_priv) && crtc_state->port_clock > 594000)
3586+
else if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
3587+
crtc_state->port_clock > 594000)
35873588
crtc_state->min_voltage_level = 3;
35883589
else if (DISPLAY_VER(dev_priv) >= 11 && crtc_state->port_clock > 594000)
35893590
crtc_state->min_voltage_level = 1;
@@ -4878,7 +4879,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
48784879
encoder->disable_clock = dg1_ddi_disable_clock;
48794880
encoder->is_clock_enabled = dg1_ddi_is_clock_enabled;
48804881
encoder->get_config = dg1_ddi_get_config;
4881-
} else if (IS_JSL_EHL(dev_priv)) {
4882+
} else if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) {
48824883
if (intel_ddi_is_tc(dev_priv, port)) {
48834884
encoder->enable_clock = jsl_ddi_tc_enable_clock;
48844885
encoder->disable_clock = jsl_ddi_tc_disable_clock;
@@ -4949,7 +4950,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv,
49494950
encoder->hpd_pin = rkl_hpd_pin(dev_priv, port);
49504951
else if (DISPLAY_VER(dev_priv) >= 12)
49514952
encoder->hpd_pin = tgl_hpd_pin(dev_priv, port);
4952-
else if (IS_JSL_EHL(dev_priv))
4953+
else if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv))
49534954
encoder->hpd_pin = ehl_hpd_pin(dev_priv, port);
49544955
else if (DISPLAY_VER(dev_priv) == 11)
49554956
encoder->hpd_pin = icl_hpd_pin(dev_priv, port);

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1749,7 +1749,7 @@ bool intel_phy_is_combo(struct drm_i915_private *dev_priv, enum phy phy)
17491749
return phy <= PHY_E;
17501750
else if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
17511751
return phy <= PHY_D;
1752-
else if (IS_JSL_EHL(dev_priv))
1752+
else if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv))
17531753
return phy <= PHY_C;
17541754
else if (IS_ALDERLAKE_P(dev_priv) || IS_DISPLAY_VER(dev_priv, 11, 12))
17551755
return phy <= PHY_B;
@@ -1801,7 +1801,8 @@ enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port)
18011801
return PHY_B + port - PORT_TC1;
18021802
else if ((IS_DG1(i915) || IS_ROCKETLAKE(i915)) && port >= PORT_TC1)
18031803
return PHY_C + port - PORT_TC1;
1804-
else if (IS_JSL_EHL(i915) && port == PORT_D)
1804+
else if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) &&
1805+
port == PORT_D)
18051806
return PHY_A;
18061807

18071808
return PHY_A + port - PORT_A;

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
500500
else if (IS_ALDERLAKE_P(dev_priv) || IS_ALDERLAKE_S(dev_priv) ||
501501
IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
502502
max_rate = 810000;
503-
else if (IS_JSL_EHL(dev_priv))
503+
else if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv))
504504
max_rate = ehl_max_source_rate(intel_dp);
505505
else
506506
max_rate = icl_max_source_rate(intel_dp);

drivers/gpu/drm/i915/display/intel_dpll_mgr.c

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ intel_combo_pll_enable_reg(struct drm_i915_private *i915,
191191
{
192192
if (IS_DG1(i915))
193193
return DG1_DPLL_ENABLE(pll->info->id);
194-
else if (IS_JSL_EHL(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))
194+
else if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) &&
195+
(pll->info->id == DPLL_ID_EHL_DPLL4))
195196
return MG_PLL_ENABLE(0);
196197

197198
return ICL_DPLL_ENABLE(pll->info->id);
@@ -2460,8 +2461,8 @@ static void icl_wrpll_params_populate(struct skl_wrpll_params *params,
24602461
static bool
24612462
ehl_combo_pll_div_frac_wa_needed(struct drm_i915_private *i915)
24622463
{
2463-
return ((IS_PLATFORM(i915, INTEL_ELKHARTLAKE) &&
2464-
IS_JSL_EHL_DISPLAY_STEP(i915, STEP_B0, STEP_FOREVER)) ||
2464+
return (((IS_ELKHARTLAKE(i915) || IS_JASPERLAKE(i915)) &&
2465+
IS_DISPLAY_STEP(i915, STEP_B0, STEP_FOREVER)) ||
24652466
IS_TIGERLAKE(i915) || IS_ALDERLAKE_S(i915) || IS_ALDERLAKE_P(i915)) &&
24662467
i915->display.dpll.ref_clks.nssc == 38400;
24672468
}
@@ -3226,7 +3227,8 @@ static int icl_get_combo_phy_dpll(struct intel_atomic_state *state,
32263227
BIT(DPLL_ID_EHL_DPLL4) |
32273228
BIT(DPLL_ID_ICL_DPLL1) |
32283229
BIT(DPLL_ID_ICL_DPLL0);
3229-
} else if (IS_JSL_EHL(dev_priv) && port != PORT_A) {
3230+
} else if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
3231+
port != PORT_A) {
32303232
dpll_mask =
32313233
BIT(DPLL_ID_EHL_DPLL4) |
32323234
BIT(DPLL_ID_ICL_DPLL1) |
@@ -3567,7 +3569,8 @@ static bool icl_pll_get_hw_state(struct drm_i915_private *dev_priv,
35673569
hw_state->div0 &= TGL_DPLL0_DIV0_AFC_STARTUP_MASK;
35683570
}
35693571
} else {
3570-
if (IS_JSL_EHL(dev_priv) && id == DPLL_ID_EHL_DPLL4) {
3572+
if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
3573+
id == DPLL_ID_EHL_DPLL4) {
35713574
hw_state->cfgcr0 = intel_de_read(dev_priv,
35723575
ICL_DPLL_CFGCR0(4));
35733576
hw_state->cfgcr1 = intel_de_read(dev_priv,
@@ -3623,7 +3626,8 @@ static void icl_dpll_write(struct drm_i915_private *dev_priv,
36233626
cfgcr1_reg = TGL_DPLL_CFGCR1(id);
36243627
div0_reg = TGL_DPLL0_DIV0(id);
36253628
} else {
3626-
if (IS_JSL_EHL(dev_priv) && id == DPLL_ID_EHL_DPLL4) {
3629+
if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
3630+
id == DPLL_ID_EHL_DPLL4) {
36273631
cfgcr0_reg = ICL_DPLL_CFGCR0(4);
36283632
cfgcr1_reg = ICL_DPLL_CFGCR1(4);
36293633
} else {
@@ -3806,7 +3810,7 @@ static void combo_pll_enable(struct drm_i915_private *dev_priv,
38063810
{
38073811
i915_reg_t enable_reg = intel_combo_pll_enable_reg(dev_priv, pll);
38083812

3809-
if (IS_JSL_EHL(dev_priv) &&
3813+
if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
38103814
pll->info->id == DPLL_ID_EHL_DPLL4) {
38113815

38123816
/*
@@ -3914,7 +3918,7 @@ static void combo_pll_disable(struct drm_i915_private *dev_priv,
39143918

39153919
icl_pll_disable(dev_priv, pll, enable_reg);
39163920

3917-
if (IS_JSL_EHL(dev_priv) &&
3921+
if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
39183922
pll->info->id == DPLL_ID_EHL_DPLL4)
39193923
intel_display_power_put(dev_priv, POWER_DOMAIN_DC_OFF,
39203924
pll->wakeref);
@@ -4150,7 +4154,7 @@ void intel_shared_dpll_init(struct drm_i915_private *dev_priv)
41504154
dpll_mgr = &rkl_pll_mgr;
41514155
else if (DISPLAY_VER(dev_priv) >= 12)
41524156
dpll_mgr = &tgl_pll_mgr;
4153-
else if (IS_JSL_EHL(dev_priv))
4157+
else if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv))
41544158
dpll_mgr = &ehl_pll_mgr;
41554159
else if (DISPLAY_VER(dev_priv) >= 11)
41564160
dpll_mgr = &icl_pll_mgr;
@@ -4335,7 +4339,8 @@ static void readout_dpll_hw_state(struct drm_i915_private *i915,
43354339

43364340
pll->on = intel_dpll_get_hw_state(i915, pll, &pll->state.hw_state);
43374341

4338-
if (IS_JSL_EHL(i915) && pll->on &&
4342+
if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) &&
4343+
pll->on &&
43394344
pll->info->id == DPLL_ID_EHL_DPLL4) {
43404345
pll->wakeref = intel_display_power_get(i915,
43414346
POWER_DOMAIN_DC_OFF);

drivers/gpu/drm/i915/display/intel_hdmi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2894,7 +2894,8 @@ static u8 intel_hdmi_default_ddc_pin(struct intel_encoder *encoder)
28942894
ddc_pin = rkl_port_to_ddc_pin(dev_priv, port);
28952895
else if (DISPLAY_VER(dev_priv) == 9 && HAS_PCH_TGP(dev_priv))
28962896
ddc_pin = gen9bc_tgp_port_to_ddc_pin(dev_priv, port);
2897-
else if (IS_JSL_EHL(dev_priv) && HAS_PCH_TGP(dev_priv))
2897+
else if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) &&
2898+
HAS_PCH_TGP(dev_priv))
28982899
ddc_pin = mcc_port_to_ddc_pin(dev_priv, port);
28992900
else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP)
29002901
ddc_pin = icl_port_to_ddc_pin(dev_priv, port);

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,7 +1074,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
10741074
return false;
10751075

10761076
/* JSL and EHL only supports eDP 1.3 */
1077-
if (IS_JSL_EHL(dev_priv)) {
1077+
if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) {
10781078
drm_dbg_kms(&dev_priv->drm, "PSR2 not supported by phy\n");
10791079
return false;
10801080
}

drivers/gpu/drm/i915/gem/i915_gem_object.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ bool i915_gem_object_can_bypass_llc(struct drm_i915_gem_object *obj)
226226
* it, but since i915 takes the stance of always zeroing memory before
227227
* handing it to userspace, we need to prevent this.
228228
*/
229-
return IS_JSL_EHL(i915);
229+
return (IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915));
230230
}
231231

232232
static void i915_gem_close_object(struct drm_gem_object *gem, struct drm_file *file)

0 commit comments

Comments
 (0)