Skip to content

Commit 0ca870c

Browse files
MarijnS95lumag
authored andcommitted
drm/msm/dsi: Appropriately set dsc->mux_word_size based on bpc
This field is currently unread but will come into effect when duplicated code below is migrated to call drm_dsc_compute_rc_parameters(), which uses the bpc-dependent value of the local variable mux_words_size in much the same way. The hardcoded constant seems to be a remnant from the `/* bpc 8 */` comment right above, indicating that this group of field assignments is applicable to bpc = 8 exclusively and should probably bail out on different bpc values, until constants for other bpc values are added (or the current ones are confirmed to be correct across multiple bpc's). Fixes: b908032 ("drm/msm/dsi: add support for dsc data") Reviewed-by: Abhinav Kumar <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Marijn Suijten <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/508943/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Baryshkov <[email protected]>
1 parent e443459 commit 0ca870c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/dsi/dsi_host.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1786,6 +1786,7 @@ static int dsi_populate_dsc_params(struct drm_dsc_config *dsc)
17861786
if (dsc->bits_per_component == 12)
17871787
mux_words_size = 64;
17881788

1789+
dsc->mux_word_size = mux_words_size;
17891790
dsc->initial_xmit_delay = 512;
17901791
dsc->initial_scale_value = 32;
17911792
dsc->first_line_bpg_offset = 12;
@@ -1796,7 +1797,6 @@ static int dsi_populate_dsc_params(struct drm_dsc_config *dsc)
17961797
dsc->flatness_max_qp = 12;
17971798
dsc->rc_quant_incr_limit0 = 11;
17981799
dsc->rc_quant_incr_limit1 = 11;
1799-
dsc->mux_word_size = DSC_MUX_WORD_SIZE_8_10_BPC;
18001800

18011801
/* FIXME: need to call drm_dsc_compute_rc_parameters() so that rest of
18021802
* params are calculated

0 commit comments

Comments
 (0)