Skip to content

Commit 0d33b1b

Browse files
committed
KVM: x86: leave vcpu->arch.pio.count alone in emulator_pio_in_out
Currently emulator_pio_in clears vcpu->arch.pio.count twice if emulator_pio_in_out performs kernel PIO. Move the clear into emulator_pio_out where it is actually necessary. No functional change intended. Cc: [email protected] Fixes: 7ed9abf ("KVM: SVM: Support string IO operations for an SEV-ES guest") Reviewed-by: Maxim Levitsky <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent b599840 commit 0d33b1b

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

arch/x86/kvm/x86.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6914,10 +6914,8 @@ static int emulator_pio_in_out(struct kvm_vcpu *vcpu, int size,
69146914
vcpu->arch.pio.count = count;
69156915
vcpu->arch.pio.size = size;
69166916

6917-
if (!kernel_pio(vcpu, vcpu->arch.pio_data)) {
6918-
vcpu->arch.pio.count = 0;
6917+
if (!kernel_pio(vcpu, vcpu->arch.pio_data))
69196918
return 1;
6920-
}
69216919

69226920
vcpu->run->exit_reason = KVM_EXIT_IO;
69236921
vcpu->run->io.direction = in ? KVM_EXIT_IO_IN : KVM_EXIT_IO_OUT;
@@ -6963,9 +6961,16 @@ static int emulator_pio_out(struct kvm_vcpu *vcpu, int size,
69636961
unsigned short port, const void *val,
69646962
unsigned int count)
69656963
{
6964+
int ret;
6965+
69666966
memcpy(vcpu->arch.pio_data, val, size * count);
69676967
trace_kvm_pio(KVM_PIO_OUT, port, size, count, vcpu->arch.pio_data);
6968-
return emulator_pio_in_out(vcpu, size, port, (void *)val, count, false);
6968+
ret = emulator_pio_in_out(vcpu, size, port, (void *)val, count, false);
6969+
if (ret)
6970+
vcpu->arch.pio.count = 0;
6971+
6972+
return ret;
6973+
69696974
}
69706975

69716976
static int emulator_pio_out_emulated(struct x86_emulate_ctxt *ctxt,

0 commit comments

Comments
 (0)